-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #112 from hpi-swa-teaching/91b-if-this-is-gonna-wo…
…rk-we-just-wasted-five-hours Add linting tests
- Loading branch information
Showing
249 changed files
with
1,398 additions
and
203 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
|
||
# This is a basic workflow to help you get started with Actions | ||
|
||
name: Linter | ||
|
||
# Controls when the action will run. Triggers the workflow on push or pull request events on every branch | ||
on: [push, pull_request] | ||
|
||
# A workflow run is made up of one or more jobs that can run sequentially or in parallel | ||
jobs: | ||
# This workflow contains a single job called "build" | ||
build: | ||
# The type of runner that the job will run on | ||
runs-on: ubuntu-latest | ||
name: Squeak64-5.3 on ubuntu-latest | ||
# Steps represent a sequence of tasks that will be executed as part of the job | ||
steps: | ||
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it | ||
- uses: actions/checkout@v2 | ||
- name: Setup smalltalkCI | ||
uses: hpi-swa/setup-smalltalkCI@1.1.0 | ||
with: | ||
smalltalk-version: Squeak64-5.3 | ||
- name: Test ChangesBrowser | ||
run: smalltalkci -s Squeak64-5.3 .linter.ston | ||
shell: bash | ||
timeout-minutes: 15 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
SmalltalkCISpec { | ||
#preLoading : 'scripts/preLoading.st', | ||
#loading : [ | ||
SCIMetacelloLoadSpec { | ||
#baseline : 'ChangesReloaded', | ||
#directory : 'packages', | ||
#load : 'Tests', | ||
#platforms : [ #squeak ] | ||
} | ||
], | ||
#testing : { | ||
#classes : [ #CRLinter ] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,4 @@ language: smalltalk | |
sudo: false | ||
|
||
smalltalk: | ||
- Squeak-trunk | ||
- Squeak64-5.3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
...es/BaselineOfChangesReloaded.package/BaselineOfChangesReloaded.class/instance/postLoad.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
baseline | ||
postLoad | ||
|
||
(Smalltalk globals at: #SwaLint) perform: #install |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
packages/Changes-Core.package/CHBrowser.class/instance/switchToSimpleView.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
button-actions | ||
switchToSimpleView | ||
|
||
"Open the CRBrowser, which offers a simpler view for the changes." | ||
CRBrowser open. | ||
self changed: #close | ||
|
||
self changed: #close. | ||
^ CRBrowser open |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
{ | ||
#serializer : #SquotCypressCodeSerializer, | ||
#objectClassName : #PackageInfo | ||
SquotTrackedObjectMetadata { | ||
#objectClassName : #PackageInfo, | ||
#objectsReplacedByNames : true, | ||
#serializer : #SquotCypressCodeSerializer | ||
} |
10 changes: 5 additions & 5 deletions
10
packages/Changes-Tests.package/CHFakeFileStream.class/instance/upTo..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
overwriting | ||
upTo: delimiter | ||
| returnString | | ||
returnString := ''. | ||
[(self position < self string size) and: (self peek ~~ delimiter)] whileTrue: [ returnString := returnString , self next]. | ||
self position: self position + 1. | ||
^ returnString | ||
| returnString | | ||
returnString := ''. | ||
[(self position < self string size) and: (self peek ~~ delimiter)] whileTrue: [ returnString := returnString , self next]. | ||
self position: self position + 1. | ||
^ returnString |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
packages/ChangesReloaded-Core.package/CRBrowser.class/class/changeListName.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
constants | ||
changeListName | ||
|
||
^ 'change list' |
18 changes: 18 additions & 0 deletions
18
packages/ChangesReloaded-Core.package/CRBrowser.class/class/getHistoryListFrom..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
utils | ||
getHistoryListFrom: anOrderedCollectionOfChangeRecords | ||
|
||
| history | | ||
history := Dictionary new. | ||
(anOrderedCollectionOfChangeRecords | ||
select: [:each | each isMethod]) | ||
do: [:each | | ||
| changeListItem historyItem historyItemKey | | ||
changeListItem := CRChangeListItem new changeRecord: each. | ||
historyItemKey := each methodClassName , each methodSelector. | ||
historyItem := history | ||
at: historyItemKey | ||
ifAbsentPut: [CRHistoryListItem | ||
newWithSelector: (each methodSelector) | ||
andClass: (each methodClass)]. | ||
historyItem addItem: changeListItem]. | ||
^ history asSortedCollection sort: [:a :b | a > b] |
4 changes: 4 additions & 0 deletions
4
packages/ChangesReloaded-Core.package/CRBrowser.class/class/historyListName.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
constants | ||
historyListName | ||
|
||
^ 'history list' |
4 changes: 4 additions & 0 deletions
4
packages/ChangesReloaded-Core.package/CRBrowser.class/class/newWith..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
instance-creation | ||
newWith: aMultiByteFileStream | ||
|
||
^ self basicNew initializeWith: aMultiByteFileStream |
2 changes: 1 addition & 1 deletion
2
packages/ChangesReloaded-Core.package/CRBrowser.class/class/open.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
instance-creation | ||
open | ||
|
||
^ ToolBuilder open: self new | ||
^ self openWith: (SourceFiles second) |
4 changes: 4 additions & 0 deletions
4
packages/ChangesReloaded-Core.package/CRBrowser.class/class/openWith..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
instance-creation | ||
openWith: aMultiByteFileStream | ||
|
||
^ ToolBuilder open: (self newWith: aMultiByteFileStream) |
12 changes: 12 additions & 0 deletions
12
packages/ChangesReloaded-Core.package/CRBrowser.class/class/retrieveChangeRecordsFrom..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
utils | ||
retrieveChangeRecordsFrom: aMultiByteFileStream | ||
|
||
| changesFileCopy start end | | ||
changesFileCopy := aMultiByteFileStream readOnlyCopy. | ||
changesFileCopy setConverterForCode. | ||
end := changesFileCopy size. | ||
start := 0 max: (end - self numberOfBytesToLoadChangesFrom). | ||
|
||
^ ChangeList new | ||
scanFile: changesFileCopy from: start to: end; | ||
changeList |
9 changes: 5 additions & 4 deletions
9
packages/ChangesReloaded-Core.package/CRBrowser.class/instance/buildButtonPanelSpecWith..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
building | ||
toolbuilder | ||
buildButtonPanelSpecWith: aBuilder | ||
|
||
^ aBuilder pluggablePanelSpec new | ||
model: self; | ||
layout: #horizontal; | ||
children: (self buildButtonSpecsWith: aBuilder) | ||
model: self; | ||
layout: #horizontal; | ||
children: (self buildButtonSpecsWith: aBuilder); | ||
yourself |
2 changes: 1 addition & 1 deletion
2
packages/ChangesReloaded-Core.package/CRBrowser.class/instance/buildButtonSpecsWith..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
building | ||
toolbuilder | ||
buildButtonSpecsWith: aBuilder | ||
|
||
^ (self buttons | ||
|
6 changes: 4 additions & 2 deletions
6
packages/ChangesReloaded-Core.package/CRBrowser.class/instance/buildHistoryListSpecWith..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,11 @@ | ||
building | ||
toolbuilder | ||
buildHistoryListSpecWith: aBuilder | ||
|
||
^ aBuilder pluggableListSpec new | ||
name: self class historyListName; | ||
model: self; | ||
list: #historyDescriptions; | ||
getIndex: #historyListSelectionIndex; | ||
setIndex: #historyListSelectionIndex:; | ||
menu: #setUpHistoryListMenuMorph: | ||
menu: #setUpHistoryListMenuMorph:; | ||
yourself |
6 changes: 4 additions & 2 deletions
6
...Reloaded-Core.package/CRBrowser.class/instance/buildSingleSelectionChangeListSpecWith..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,10 @@ | ||
building | ||
toolbuilder | ||
buildSingleSelectionChangeListSpecWith: aBuilder | ||
|
||
^ aBuilder pluggableListSpec new | ||
name: self class changeListName; | ||
model: self; | ||
list: #displayedChangeDescriptions; | ||
getIndex: #changeListSelectionIndex; | ||
setIndex: #changeListSelectionIndex: | ||
setIndex: #changeListSelectionIndex:; | ||
yourself |
2 changes: 1 addition & 1 deletion
2
packages/ChangesReloaded-Core.package/CRBrowser.class/instance/buildWith..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
building | ||
toolbuilder | ||
buildWith: aBuilder | ||
|
||
^ aBuilder build: (aBuilder pluggableWindowSpec new | ||
|
2 changes: 1 addition & 1 deletion
2
packages/ChangesReloaded-Core.package/CRBrowser.class/instance/buttonHeight.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
building | ||
toolbuilder | ||
buttonHeight | ||
|
||
^ 50 |
2 changes: 1 addition & 1 deletion
2
packages/ChangesReloaded-Core.package/CRBrowser.class/instance/buttons.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 3 additions & 2 deletions
5
packages/ChangesReloaded-Core.package/CRBrowser.class/instance/buttonsFrame.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
building | ||
toolbuilder | ||
buttonsFrame | ||
|
||
^ LayoutFrame new | ||
leftFraction: 0 offset: 0; | ||
topFraction: 0 offset: 0; | ||
rightFraction: 1 offset: 0; | ||
bottomFraction: 0 offset: self buttonHeight | ||
bottomFraction: 0 offset: self buttonHeight; | ||
yourself |
5 changes: 3 additions & 2 deletions
5
packages/ChangesReloaded-Core.package/CRBrowser.class/instance/changeListFrame.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
building | ||
toolbuilder | ||
changeListFrame | ||
|
||
^ LayoutFrame new | ||
leftFraction: 0.5 offset: 0; | ||
topFraction: 0 offset: self buttonHeight; | ||
rightFraction: 1 offset: 0; | ||
bottomFraction: 1 - self codePaneFraction offset: 0 | ||
bottomFraction: 1 - self codePaneFraction offset: 0; | ||
yourself |
2 changes: 1 addition & 1 deletion
2
packages/ChangesReloaded-Core.package/CRBrowser.class/instance/codePaneFraction.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
building | ||
toolbuilder | ||
codePaneFraction | ||
|
||
^ 0.45 |
5 changes: 3 additions & 2 deletions
5
packages/ChangesReloaded-Core.package/CRBrowser.class/instance/codePaneFrame.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
building | ||
toolbuilder | ||
codePaneFrame | ||
|
||
^ LayoutFrame new | ||
leftFraction: 0 offset: 0; | ||
topFraction: 1 - self codePaneFraction offset: 0; | ||
rightFraction: 1 offset: 0; | ||
bottomFraction: 1 offset: 0 | ||
bottomFraction: 1 offset: 0; | ||
yourself |
4 changes: 2 additions & 2 deletions
4
packages/ChangesReloaded-Core.package/CRBrowser.class/instance/extent.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
building | ||
toolbuilder | ||
extent | ||
|
||
^ 500@500 | ||
^ 500 @ 500 |
18 changes: 0 additions & 18 deletions
18
packages/ChangesReloaded-Core.package/CRBrowser.class/instance/getHistoryListFrom..st
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.