Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untrack System-Changes #94

Merged
merged 4 commits into from
Jun 29, 2020
Merged

Untrack System-Changes #94

merged 4 commits into from
Jun 29, 2020

Conversation

MarcelGarus
Copy link
Member

@MarcelGarus MarcelGarus commented Jun 22, 2020

Closes #93

Untracks and removes the System-Changes package from our repository.

Delete it

Copy link
Contributor

@strawberriesandcheese strawberriesandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just beautiful

@MarcelGarus
Copy link
Member Author

MarcelGarus commented Jun 28, 2020

I was wondering how this could possibly decrease the coverage, but it seems like coveralls doesn't know about branches, so because the coverage increased in another branch, coveralls is like "wait a minute, I've seen better coverage for ChangesReloaded somewhere. Denied!"
So, I guess we should go ahead and merge this?

@SilvanVerhoeven
Copy link
Contributor

I was wondering how this could possibly decrease the coverage, but it seems like coveralls doesn't know about branches, so because the coverage increased in another branch, coveralls is like "wait a minute, I've seen better coverage for ChangesReloaded somewhere. Denied!"
So, I guess we should go ahead and merge this?

Sounds good to me

@MarcelGarus MarcelGarus merged commit cbcbdd0 into dev Jun 29, 2020
@MarcelGarus MarcelGarus deleted the 93-untrack-system-changes branch June 29, 2020 17:03
@MarcelGarus MarcelGarus restored the 93-untrack-system-changes branch July 2, 2020 12:49
@AbdullatifGhajar AbdullatifGhajar deleted the 93-untrack-system-changes branch June 11, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up repository
4 participants