fix bug where translucent colors are eliminated after color inversion

hpi-swa-teaching · May 26, 2021 · dd4dd1e · dd4dd1e
1 parent 14214f7
commit dd4dd1e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/packages/IconAPI-Core.package/IconMorph.class/instance/invertWithTransparency.st b/packages/IconAPI-Core.package/IconMorph.class/instance/invertWithTransparency.st
@@ -8,7 +8,8 @@ invertWithTransparency
 		|value alpha red green blue|
 		value := bitmap at: pixelIndex.
 		alpha := value bitShift: -24.
-		red := 255 - ((value bitShift: -16) bitAnd: 255).
-		green := 255 - ((value bitShift: -8) bitAnd: 255).
-		blue := 255 - (value bitAnd: 255).
-		bitmap at: pixelIndex put: (alpha bitShift: 24) + (red bitShift: 16) + (green bitShift: 8) + blue]
+		alpha >  0 ifTrue: [
+			red := 255 - ((value bitShift: -16) bitAnd: 255).
+			green := 255 - ((value bitShift: -8) bitAnd: 255).
+			blue := 255 - (value bitAnd: 255).
+			bitmap at: pixelIndex put: (alpha bitShift: 24) + (red bitShift: 16) + (green bitShift: 8) + blue]]
diff --git a/packages/IconAPI-Core.package/IconMorph.class/methodProperties.json b/packages/IconAPI-Core.package/IconMorph.class/methodProperties.json
@@ -13,7 +13,7 @@
 		"iconSize" : "han 5/14/2021 11:40",
 		"iconSize:" : "han 5/14/2021 11:41",
 		"invert" : "AW 5/26/2021 14:26",
-		"invertWithTransparency" : "AW 5/26/2021 14:27",
+		"invertWithTransparency" : "AW 5/26/2021 15:02",
 		"invertWithoutTransparency" : "AW 5/26/2021 14:26",
 		"setIcon:" : "hw 5/18/2021 21:15",
 		"setIconColor:" : "hw 5/25/2021 22:04",