HTML Comment Blocks #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lara Pfennigschmidt <lara.pfennigschmidt@student.hpi.de> Co-authored-by: Kira Grammel <kira.grammel@student.hpi.de>
-makes it consistent with the BlockTextStyler Co-authored-by: Lara Pfennigschmidt <lara.pfennigschmidt@student.hpi.de>
felix-gohla
reviewed
Jun 25, 2019
...itor-Tests.package/MarkdownCommentBlockTests.class/instance/testMismatchGTAfterOpeningTag.st
Outdated
Show resolved
Hide resolved
...Tests.package/MarkdownCommentBlockTests.class/instance/testMismatchMinusGTAfterOpeningTag.st
Outdated
Show resolved
Hide resolved
kiragrammel
approved these changes
Jun 27, 2019
packages/MarkdownEditor-Core.package/MarkdownCommentBlock.class/class/matches..st
Outdated
Show resolved
Hide resolved
packages/MarkdownEditor-Core.package/MarkdownCommentBlock.class/instance/commentEnd.st
Outdated
Show resolved
Hide resolved
lpfennigschmidt
approved these changes
Jun 27, 2019
packages/MarkdownEditor-Core.package/MarkdownCommentBlock.class/class/matches..st
Outdated
Show resolved
Hide resolved
packages/MarkdownEditor-Core.package/MarkdownCommentBlock.class/instance/commentEnd.st
Outdated
Show resolved
Hide resolved
jonaskordt
commented
Jun 27, 2019
packages/MarkdownEditor-Core.package/MarkdownCommentBlock.class/class/matches..st
Outdated
Show resolved
Hide resolved
-removes magic numbers and magic strings
jonaskordt
commented
Jun 27, 2019
packages/MarkdownEditor-Core.package/MarkdownCommentBlock.class/instance/commentStart.st
Outdated
Show resolved
Hide resolved
pixunil
requested changes
Jun 28, 2019
packages/MarkdownEditor-Core.package/MarkdownCommentBlock.class/instance/asText.st
Outdated
Show resolved
Hide resolved
packages/MarkdownEditor-Core.package/MarkdownParagraph.class/class/matches..st
Outdated
Show resolved
Hide resolved
...nBlockTextStylerTest.class/instance/testBlockStructureCommentBlockNotInterruptedByHeading.st
Show resolved
Hide resolved
...itor-Tests.package/MarkdownCommentBlockTests.class/instance/assertRuns.values.areStyleOf..st
Show resolved
Hide resolved
...or-Tests.package/MarkdownCommentBlockTests.class/instance/testClosingTagInFirstLineCloses.st
Outdated
Show resolved
Hide resolved
|
|
||
| | commentBlock | | ||
| commentBlock := MarkdownCommentBlock newFrom: '<!-- MiniMetro', Character cr. | ||
| commentBlock append: 'is great --> more Text'. |
There was a problem hiding this comment.
commentBlock := MarkdownCommentBlock newFrom: '<!-- Comment with', Character cr.
commentBlock append: 'multiple lines --> Text after end tag'.Applies to other isClosed and commentEnd tests
There was a problem hiding this comment.
Meh. I think it's pretty clear like it is...
...or-Tests.package/MarkdownCommentBlockTests.class/instance/testCommentStart0To3Indentation.st
Outdated
Show resolved
Hide resolved
| tests - matching | ||
| testMismatchOverlappingOpeningAndClosingTag | ||
|
|
||
| self deny: (MarkdownCommentBlock matches: '<!-->'). |
There was a problem hiding this comment.
after reading the spec, I think that the rules
- Up to 3 indentation
- Begins with
<!--
are sufficient. It differs for inline comments though, where <!--> and <!---> and <!-- -- --> are forbidden.
So I think these tests are wrong and you can remove some lines in matches:. But maybe I just misread the spec...
There was a problem hiding this comment.
Hm seems like you are right. I think it's confusing that they have different rules abut trying it with https://spec.commonmark.org/dingus/ gives the result you described.
(I changed it already but didn't resolve it to avoid confusion)
-corrects `MarkdonwCommentBlock>>matches:` to comply with spec -improves some coding standards -adds accessort for `openingTag` and `closingTag` on instance side of `MarkdownCommentBlock`
pixunil
approved these changes
Jun 29, 2019
packages/MarkdownEditor-Core.package/MarkdownCommentBlock.class/class/closingTag.st
Outdated
Show resolved
Hide resolved
packages/MarkdownEditor-Core.package/MarkdownCommentBlock.class/instance/commentEnd.st
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready and can be reviewed even though the tests in 5.0 are failing as we plan to no longer support 5.0. No reason why you couldn't review it yet though.
Obviously merging will have to wait for the removal of 5.0 support.