Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color themes #162

Merged
merged 12 commits into from
Jun 11, 2019
Merged

Color themes #162

merged 12 commits into from
Jun 11, 2019

Conversation

LucPrestin
Copy link
Contributor

@LucPrestin LucPrestin commented Jun 4, 2019 •
edited
Loading

Issue: #8 done

Geschätzte Käsekuchen: 8
Gebrauchte Käsekuchen: 8

@LucPrestin LucPrestin added this to Backlog (Ideas) in General via automation Jun 4, 2019
@coveralls
Copy link

coveralls commented Jun 4, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 511

  • 196 of 267 (73.41%) changed or added relevant lines in 48 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 78.791%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/Material-Core.package/MDColorTheme.class/instance/backgroundColor.st 0 4 0.0%
packages/Material-Core.package/MDColorTheme.class/instance/disabledColor.st 0 4 0.0%
packages/Material-Core.package/MDColorTheme.class/instance/errorColor.st 0 4 0.0%
packages/Material-Core.package/MDColorTheme.class/instance/primaryColorDark.st 0 4 0.0%
packages/Material-Core.package/MDColorTheme.class/instance/primaryColorDarkVariants.st 0 4 0.0%
packages/Material-Core.package/MDColorTheme.class/instance/primaryColorDarkest.st 0 4 0.0%
packages/Material-Core.package/MDColorTheme.class/instance/primaryColorLight.st 0 4 0.0%
packages/Material-Core.package/MDColorTheme.class/instance/primaryColorLightVariants.st 0 4 0.0%
packages/Material-Core.package/MDColorTheme.class/instance/primaryColorLightest.st 0 4 0.0%
packages/Material-Core.package/MDColorTheme.class/instance/secondaryColorDark.st 0 4 0.0%
Totals Coverage Status
Change from base Build 492: -0.3%
Covered Lines: 4001
Relevant Lines: 5078
💛 - Coveralls

@LucPrestin LucPrestin moved this from Backlog (Ideas) to In progress in General Jun 6, 2019
LoWanda
LoWanda requested changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@LoWanda LoWanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mir sind ein paar Punkte aufgefallen, die weg können ^^
Außerdem gibt es ein paar magic numbers (z.B. alpha: 0.6), da sollten wir uns vielleicht noch was überlegen.

packages/Material-Core.package/MDColorTheme.class/class/currentTheme.st Outdated Show resolved Hide resolved
packages/Material-Core.package/MDColorTheme.class/instance/calculateDarkVariants..st Outdated Show resolved Hide resolved
packages/Material-Core.package/MDColorTheme.class/instance/calculateLightVariants..st Outdated Show resolved Hide resolved
packages/Material-Core.package/MDColorTheme.class/instance/primaryColorDark.st Outdated Show resolved Hide resolved
packages/Material-Core.package/MDColorTheme.class/instance/primaryColorDarkest.st Outdated Show resolved Hide resolved
packages/Material-Core.package/MDColorTheme.class/instance/secondaryColorLight.st Outdated Show resolved Hide resolved
packages/Material-Core.package/MDColorTheme.class/instance/secondaryColorLightest.st Outdated Show resolved Hide resolved
packages/Material-Core.package/MDColorTheme.class/instance/showColors.st Outdated Show resolved Hide resolved
packages/Material-Core.package/MDColorTheme.class/instance/textColorOn..st Outdated Show resolved Hide resolved
packages/Material-Tests.package/MDColorThemeTest.class/instance/setUp.st Outdated Show resolved Hide resolved
robinwersich
robinwersich reviewed Jun 10, 2019
View reviewed changes
packages/Material-Core.package/MDButton.class/instance/checkToggled.st Outdated Show resolved Hide resolved
packages/Material-Core.package/MDColorTheme.class/README.md Outdated Show resolved Hide resolved
packages/Material-Core.package/MDColorTheme.class/class/defaultBackgroundColor.st Outdated Show resolved Hide resolved
packages/Material-Core.package/MDColorTheme.class/instance/calculateDarkVariants..st Outdated Show resolved Hide resolved
packages/Material-Core.package/MDColorTheme.class/instance/primaryColorLight.st Outdated Show resolved Hide resolved
packages/Material-Core.package/MDDialog.class/class/titleTextColor.st Show resolved Hide resolved
packages/Material-Core.package/MDDialog.class/instance/initialize.st Show resolved Hide resolved
packages/Material-Core.package/MDFloatingActionButton.class/class/defaultBorderRadius.st Show resolved Hide resolved
@LucPrestin LucPrestin merged commit cc03288 into develop Jun 11, 2019
General automation moved this from In progress to Review Jun 11, 2019
@LucPrestin LucPrestin moved this from Review to Done in General Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinwersich robinwersich robinwersich left review comments

@LoWanda LoWanda LoWanda requested changes

Assignees
No one assigned
Labels
User Story
Projects
General
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LucPrestin @coveralls @robinwersich @LoWanda