fixed bug and set linter rule to "dont"

hpi-swa-teaching · Jun 25, 2021 · 55239a7 · 55239a7
1 parent 543e355
commit 55239a7
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 10 deletions.
diff --git a/...MorphicAPIExplorer-Core.package/MEXToolExplorationView.class/instance/changeToOverView.st b/...MorphicAPIExplorer-Core.package/MEXToolExplorationView.class/instance/changeToOverView.st
@@ -2,7 +2,6 @@ ui
 changeToOverView
 
 	| newView |
-	self myDependents do: [:aDependent | self removeDependent: aDependent].
 	(self standardMorphs noneSatisfy: [:each | (each class = category defaultMorph class)])
 		ifTrue: [self defaultMorphs removeKey: self actualDefaultMorph].
 	newView := MEXToolOverView new.

diff --git a/packages/MorphicAPIExplorer-Core.package/MEXToolExplorationView.class/methodProperties.json b/packages/MorphicAPIExplorer-Core.package/MEXToolExplorationView.class/methodProperties.json
@@ -28,7 +28,7 @@
 		"category" : "FFN 5/9/2019 10:09",
 		"category:" : "FFN 5/9/2019 10:09",
 		"changeCurrentDefaultMorph:withSelectedMethods:" : "SH 5/20/2021 14:46",
-		"changeToOverView" : "PC 6/21/2021 20:19",
+		"changeToOverView" : "SC 6/25/2021 19:13",
 		"clearPlayground" : "FFN 7/11/2019 13:54",
 		"createDefaultMorphBox" : "PC 6/17/2021 17:47",
 		"createMorphPlayground" : "FFN 7/6/2019 23:49",

diff --git a/...ages/MorphicAPIExplorer-Tests.package/MEXExplorationViewTests.class/methodProperties.json b/...ages/MorphicAPIExplorer-Tests.package/MEXExplorationViewTests.class/methodProperties.json
@@ -3,7 +3,7 @@
 		 },
 	"instance" : {
 		"getMethodTreeFor:" : "SH 6/10/2021 19:20",
-		"getMorphCollectionInDefaultMorphBoxFor:" : " 6/21/2021 23:30:36",
+		"getMorphCollectionInDefaultMorphBoxFor:" : "6/21/2021 23:30:36",
 		"newMorphs" : "lk 7/24/2019 15:03",
 		"sampleCode" : "lk 7/24/2019 15:11",
 		"setUp" : "lk 7/24/2019 16:15",

diff --git a/packages/MorphicAPIExplorer-Tests.package/MEXLinter.class/class/excludedRules.st b/packages/MorphicAPIExplorer-Tests.package/MEXLinter.class/class/excludedRules.st
@@ -10,4 +10,5 @@ excludedRules
 		#smallLintSendsDifferentSuper .
 		#smallLintBadMessage .
 		#smallLintUtilityMethods .
-		#collectionProtocolRule:} asOrderedCollection
+		#collectionProtocolRule: .
+		#smallLintAddRemoveDependents} asOrderedCollection
diff --git a/...ge/MEXLinter.class/instance/dontTestAddDependantMethodsLessOrEqualThanRemoveDependents.st b/...ge/MEXLinter.class/instance/dontTestAddDependantMethodsLessOrEqualThanRemoveDependents.st
@@ -0,0 +1,5 @@
+test-for-possible-bugs
+dontTestAddDependantMethodsLessOrEqualThanRemoveDependents
+	"we add dependents in MEXExplorationView but need these also in MEXOverView, so we can't remove them manually"
+
+	self assertAllAreZero: (self runLinterRule: #smallLintAddRemoveDependents)
diff --git a/...ackage/MEXLinter.class/instance/testAddDependantMethodsLessOrEqualThanRemoveDependents.st b/...ackage/MEXLinter.class/instance/testAddDependantMethodsLessOrEqualThanRemoveDependents.st
diff --git a/packages/MorphicAPIExplorer-Tests.package/MEXLinter.class/methodProperties.json b/packages/MorphicAPIExplorer-Tests.package/MEXLinter.class/methodProperties.json
@@ -1,6 +1,6 @@
 {
 	"class" : {
-		"excludedRules" : "SC 6/21/2021 23:59",
+		"excludedRules" : "SC 6/25/2021 19:16",
 		"isLoggingEnabled" : "SC 6/21/2021 23:09",
 		"isLoggingVerbose" : "SC 6/21/2021 23:09",
 		"mexCorePackage" : "SC 6/14/2021 10:00",
@@ -31,6 +31,7 @@
 		"classes" : "mg 6/5/2020 11:49",
 		"classes:" : "mg 6/5/2020 11:49",
 		"defaultTimeout" : "SC 6/15/2021 22:58",
+		"dontTestAddDependantMethodsLessOrEqualThanRemoveDependents" : "SC 6/25/2021 19:15",
 		"dontTestArgumentVariableNames" : "SC 6/15/2021 23:53",
 		"dontTestDataClass" : "SC 6/15/2021 22:39",
 		"dontTestInconsistentMethodClassification" : "SC 6/15/2021 23:43",
@@ -45,7 +46,6 @@
 		"logProblemsOf:InTest:" : "SC 6/22/2021 00:18",
 		"runLinterRule:" : "SC 6/21/2021 23:10",
 		"setUp" : "SC 6/16/2021 05:58",
-		"testAddDependantMethodsLessOrEqualThanRemoveDependents" : "PC 6/21/2021 20:19",
 		"testAllDontTestsForConsoleOutputOnly" : "SC 6/21/2021 23:10",
 		"testArithmeticPrecedenceRule" : "mg 7/15/2020 20:11",
 		"testAsOrderedCollectionAsArrayNotNeeded" : "mg 7/15/2020 20:11",