Skip to content

Commit

Permalink
Linting. ref. #123
Browse files Browse the repository at this point in the history
  • Loading branch information
@rdunker
rdunker committed Jul 3, 2021
1 parent ee852a7 commit ad088e6
Show file tree
Hide file tree
Showing 21 changed files with 47 additions and 33 deletions.
1 change: 1 addition & 0 deletions packages/MusicNotation-Tests.package/MNEditorTest.class/instance/testDoItEnvironment.st
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
tests
testDoItEnvironment
| editor old |

editor := MNEditor new.
self deny: editor environment isNil.
self deny: editor doItEnvironment isNil.
Expand Down
3 changes: 2 additions & 1 deletion ...ges/MusicNotation-Tests.package/MNEditorTest.class/instance/testLocalVariableStatement.st
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
tests
testLocalVariableStatement
| editor |
| editor |

editor := MNEditor new.
editor updateContents: '| var | var := 1. var := var + 1.'.
self assert: (editor localVariablesStatement: 'var := var + 1.') = '| var |var := (self localVariables at: ''var'') + 1.^ ((Dictionary new) at: ''var'' put: var; yourself)'.
1 change: 1 addition & 0 deletions packages/MusicNotation-Tests.package/MNEditorTest.class/instance/testMenuItems.st
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
tests
testMenuItems
| editor |

editor := MNEditor new.
editor addModelItemsToWindowMenu: MenuMorph new.
1 change: 1 addition & 0 deletions packages/MusicNotation-Tests.package/MNEditorTest.class/instance/testOpenEditor.st
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
tests
testOpenEditor
| editor |

editor := MNEditor new.
self ensureAbandonOf: editor openEditor
do: [ :morph |
Expand Down
1 change: 1 addition & 0 deletions packages/MusicNotation-Tests.package/MNEditorTest.class/instance/testOpenPreview.st
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
tests
testOpenPreview
| editor |

editor := MNEditor new.
self ensureAbandonOf: editor openPreview
do: [ :morph |
Expand Down
1 change: 1 addition & 0 deletions packages/MusicNotation-Tests.package/MNEditorTest.class/instance/testSmuflFontDisplay.st
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
tests
testSmuflFontDisplay
| drawer |

drawer := MNSmuflDrawer new
canvas: self hiddenCanvas asBalloonCanvas;
color: Color red;
Expand Down
1 change: 1 addition & 0 deletions packages/MusicNotation-Tests.package/MNEditorTest.class/instance/testStatementMapping.st
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
tests
testStatementMapping
| editor |

editor := MNEditor new.
editor updateContents: 'g4/8.g4/4.'.
editor evaluateContentList.
Expand Down
1 change: 1 addition & 0 deletions packages/MusicNotation-Tests.package/MNEditorTest.class/instance/testTextContents.st
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
tests
testTextContents
| editor |

editor := MNEditor new.
editor textContents: '123'.
self assert: '123' equals: editor contents.
16 changes: 8 additions & 8 deletions packages/MusicNotation-Tests.package/MNEditorTest.class/methodProperties.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
"instance" : {
"ensureAbandonOf:do:" : "mgjm 7/5/2019 20:47",
"hiddenCanvas" : "mgjm 7/5/2019 20:06",
"testDoItEnvironment" : "fb 7/25/2019 19:32",
"testLocalVariableStatement" : "RAD 6/29/2021 12:42",
"testMenuItems" : "mgjm 7/5/2019 20:23",
"testOpenEditor" : "RAD 5/27/2021 14:20",
"testDoItEnvironment" : "RAD 7/3/2021 12:21",
"testLocalVariableStatement" : "RAD 7/3/2021 12:21",
"testMenuItems" : "RAD 7/3/2021 12:21",
"testOpenEditor" : "RAD 7/3/2021 12:21",
"testOpenEditorClass" : "mgjm 7/5/2019 20:44",
"testOpenPreview" : "mgjm 7/5/2019 20:47",
"testSmuflFontDisplay" : "mgjm 7/5/2019 20:43",
"testStatementMapping" : "RAD 6/11/2021 19:33",
"testTextContents" : "mgjm 7/5/2019 20:30" } }
"testOpenPreview" : "RAD 7/3/2021 12:21",
"testSmuflFontDisplay" : "RAD 7/3/2021 12:21",
"testStatementMapping" : "RAD 7/3/2021 12:21",
"testTextContents" : "RAD 7/3/2021 12:21" } }
1 change: 1 addition & 0 deletions packages/MusicNotation-Tests.package/MNLedgerLinesTests.class/README.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
I am a class to test the ledger lines.
2 changes: 1 addition & 1 deletion ...on-Tests.package/MNLedgerLinesTests.class/instance/createNoteWithDuration.step.octave..st
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
as yet unclassified
tests
createNoteWithDuration: aFraction step: aSymbol octave: aNumber
| pitch note noteMorph |

Expand Down
9 changes: 5 additions & 4 deletions ...ages/MusicNotation-Tests.package/MNLedgerLinesTests.class/instance/testFirstLedgerLine.st
View file
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
as yet unclassified
tests
testFirstLedgerLine
"Ignore while linting"
| noteC4 noteC5 noteC6 offset |

offset := 2.
noteC4 := self createNoteWithDuration: (1/8) step: $c octave: 4.
noteC5 := self createNoteWithDuration: (1/8) step: $c octave: 5.
noteC6 := self createNoteWithDuration: (1/8) step: $c octave: 6.

noteC4 noteLayout lines at: 1 put: ((noteC4 noteLayout lines at: 1) - offset).
noteC5 noteLayout lines at: 1 put: ((noteC5 noteLayout lines at: 1) - offset).
noteC6 noteLayout lines at: 1 put: ((noteC6 noteLayout lines at: 1) - offset).
noteC4 noteLayout lines at: 1 put: ((noteC4 noteLayout lines first) - offset).
noteC5 noteLayout lines at: 1 put: ((noteC5 noteLayout lines first) - offset).
noteC6 noteLayout lines at: 1 put: ((noteC6 noteLayout lines first) - offset).

self assert: 3 equals: (noteC4 noteLayout firstLedgerLine).
self assert: 0 equals: (noteC5 noteLayout firstLedgerLine).
Expand Down
9 changes: 5 additions & 4 deletions packages/MusicNotation-Tests.package/MNLedgerLinesTests.class/instance/testLastLedgerLine.st
View file
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
as yet unclassified
tests
testLastLedgerLine
"Ignore while linting"
| noteC4 noteC5 noteC6 offset |

offset := 2.
noteC4 := self createNoteWithDuration: (1/8) step: $c octave: 4.
noteC5 := self createNoteWithDuration: (1/8) step: $c octave: 5.
noteC6 := self createNoteWithDuration: (1/8) step: $c octave: 6.

noteC4 noteLayout lines at: 1 put: ((noteC4 noteLayout lines at: 1) - offset).
noteC5 noteLayout lines at: 1 put: ((noteC5 noteLayout lines at: 1) - offset).
noteC6 noteLayout lines at: 1 put: ((noteC6 noteLayout lines at: 1) - offset).
noteC4 noteLayout lines at: 1 put: ((noteC4 noteLayout lines first) - offset).
noteC5 noteLayout lines at: 1 put: ((noteC5 noteLayout lines first) - offset).
noteC6 noteLayout lines at: 1 put: ((noteC6 noteLayout lines first) - offset).

self assert: 3 equals: (noteC4 noteLayout lastLedgerLine).
self assert: -0.5 equals: (noteC5 noteLayout lastLedgerLine).
Expand Down
9 changes: 5 additions & 4 deletions ...ages/MusicNotation-Tests.package/MNLedgerLinesTests.class/instance/testNeedsLedgerLine.st
View file
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
as yet unclassified
tests
testNeedsLedgerLine
"Ignore while linting"
| noteC4 noteC5 noteC6 offset |

offset := 2.
noteC4 := self createNoteWithDuration: (1/8) step: $c octave: 4.
noteC5 := self createNoteWithDuration: (1/8) step: $c octave: 5.
noteC6 := self createNoteWithDuration: (1/8) step: $c octave: 6.

noteC4 noteLayout lines at: 1 put: ((noteC4 noteLayout lines at: 1) - offset).
noteC5 noteLayout lines at: 1 put: ((noteC5 noteLayout lines at: 1) - offset).
noteC6 noteLayout lines at: 1 put: ((noteC6 noteLayout lines at: 1) - offset).
noteC4 noteLayout lines at: 1 put: ((noteC4 noteLayout lines first) - offset).
noteC5 noteLayout lines at: 1 put: ((noteC5 noteLayout lines first) - offset).
noteC6 noteLayout lines at: 1 put: ((noteC6 noteLayout lines first) - offset).

self assert: true equals: (noteC4 noteLayout needsLedgerLines).
self assert: false equals: (noteC5 noteLayout needsLedgerLines).
Expand Down
6 changes: 3 additions & 3 deletions packages/MusicNotation-Tests.package/MNLedgerLinesTests.class/methodProperties.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
},
"instance" : {
"createNoteWithDuration:step:octave:" : "LH 6/30/2021 21:08",
"testFirstLedgerLine" : "LH 6/30/2021 21:52",
"testLastLedgerLine" : "LH 6/30/2021 21:52",
"testNeedsLedgerLine" : "LH 6/30/2021 21:58" } }
"testFirstLedgerLine" : "RAD 7/3/2021 12:28",
"testLastLedgerLine" : "RAD 7/3/2021 12:29",
"testNeedsLedgerLine" : "RAD 7/3/2021 12:29" } }
2 changes: 1 addition & 1 deletion packages/MusicNotation-Tests.package/MNLedgerLinesTests.class/properties.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
],
"classvars" : [
],
"commentStamp" : "",
"commentStamp" : "RAD 7/3/2021 12:24",
"instvars" : [
],
"name" : "MNLedgerLinesTests",
Expand Down
1 change: 1 addition & 0 deletions packages/MusicNotation-Tests.package/MNPlayerTest.class/README.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
I am a class to test the Music-Notation-Player package.
5 changes: 3 additions & 2 deletions packages/MusicNotation-Tests.package/MNPlayerTest.class/instance/testAddSounds.st
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
as yet unclassified
tests
testAddSounds
"ignore while liniting"
"Ignore while linting"
| generator note pitch testWithNote testWithPitch |

generator := MNSoundGenerator new.
pitch := MNPitch new
octave: 4;
Expand Down
4 changes: 2 additions & 2 deletions packages/MusicNotation-Tests.package/MNPlayerTest.class/instance/testVisitProject.st
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
as yet unclassified
tests
testVisitProject
"ignore while liniting"
"Ignore while linting"
| generator project part1 part2 measure1 measure2 note1 note2 pitch1 pitch2 |
generator := MNSoundGenerator new.
project := MNProject new.
Expand Down
4 changes: 2 additions & 2 deletions packages/MusicNotation-Tests.package/MNPlayerTest.class/methodProperties.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"class" : {
},
"instance" : {
"testAddSounds" : "LH 7/1/2021 10:34",
"testVisitProject" : "LH 7/1/2021 11:53" } }
"testAddSounds" : "RAD 7/3/2021 12:22",
"testVisitProject" : "RAD 7/3/2021 12:22" } }
2 changes: 1 addition & 1 deletion packages/MusicNotation-Tests.package/MNPlayerTest.class/properties.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
],
"classvars" : [
],
"commentStamp" : "",
"commentStamp" : "RAD 7/3/2021 12:25",
"instvars" : [
],
"name" : "MNPlayerTest",
Expand Down

0 comments on commit ad088e6

Please sign in to comment.