Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds extended music notation #29

Merged
merged 29 commits into from
Jun 19, 2019
Merged

Adds extended music notation #29

merged 29 commits into from
Jun 19, 2019

Conversation

underFlo
Copy link
Contributor

@underFlo underFlo commented Jun 10, 2019 •
edited by mgjm
Loading

ToDo

  • Add MNKey and MNClef
  • Add attributes to measure
  • Extend XML parser and writer
  • Implement new morphs
  • Extend existing morphs

This closes #28.

underFlo and others added 27 commits June 7, 2019 09:15
@underFlo
added MNKey class and support for fifths keys
7996ed2
@underFlo
added classes for key symbols and split MNKey into two subclasses
534d309
@underFlo
added support for manual keys when parsing/writing
eb0ee0b
@underFlo
added clef and time classes as well as tests
a2d0a11
@underFlo
fixed tests
761fbf6
@mgjm
Merge remote-tracking branch 'origin' into measurefifths
2018cbc
@mgjm
Changes measure time to fraction and removes MNTime
92b1efc
@mgjm
Refactores key classes
06f4073
@mgjm
Adds empty key
4718e54
@mgjm
Adds parent reference to music objects
327b06f
@mgjm
Refactores clef
d747135
@mgjm
Adds equal operator to key classes
3bf70cb
@mgjm
Adds copy conversion methods to key classes
e1cb539
@mgjm
Updates xml parser and xml writer
c1c1c52
@mgjm
Adds copy methods to music objects
84d2888 
Required to update the parent references.
@mgjm
Adds customized explorer content
53a559d
@mgjm
Adds customized print messages
b41c9f6
@mgjm
Marks MNKey as abstract
f4f0daa
@mgjm
Refactores music xml writer to music xml converter
fd66f10
@mgjm
Adds hash methods to child collection, clef and key
da1066e
@mgjm
Updates code style in xml package
a40f9f4
@mgjm
Fixes key and clef in measure
4e343fc
@mgjm
Adds key signature layout and adds clef support to note layout
14e2d22
@mgjm
Adds morph builder
55fb6fb
@mgjm
Fixes bugs in core package
c1a85cb 
Used `self` instead of `super` in remove methods.
Unexpected return in add accidental.
Typos and instance variable access.
@mgjm
Fixes typo in font and path drawer
a10e4b9
@mgjm
Fixes lint issues
40fa4ce
@mgjm mgjm changed the title MeasureAttributes Extended Music Notations Jun 18, 2019
@mgjm mgjm changed the title Extended Music Notations Extended Music Notation Jun 18, 2019
@martintaraz
Copy link

Quoting https://en.wikipedia.org/wiki/Accidental_(music):

In music, an accidental is a note of a pitch (or pitch class) that is not a member of the scale or mode indicated by the most recently applied key signature. In musical notation, the sharp (♯), flat (♭), and natural (♮) symbols, among others, mark such notes - and those symbols are also called accidentals.

The Name Accidental therefore applies in my opinion to both tone shifts for the whole piece of music and an individual note.

mgjm
mgjm approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@mgjm mgjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-Approved by @underFlo

@mgjm mgjm merged commit e80dc68 into master Jun 19, 2019
@mgjm mgjm deleted the measurefifths branch June 19, 2019 16:05
@mayer-maximilian mayer-maximilian changed the title Extended Music Notation Adds extended music notation Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgjm mgjm mgjm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Erweiterung der unterstützten Notation
3 participants
@underFlo @martintaraz @mgjm