Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds multiple pitches for scripting #44

Merged
merged 5 commits into from
Jun 28, 2019
Merged

Adds multiple pitches for scripting #44

merged 5 commits into from
Jun 28, 2019

Conversation

mgjm
Copy link
Contributor

@mgjm mgjm commented Jun 25, 2019 

"Create two C major chords (quarter note)"
c + e + g / 4 * 2;

@coveralls
Copy link

coveralls commented Jun 25, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 190

  • 194 of 194 (100.0%) changed or added relevant lines in 32 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 61.471%
Totals Coverage Status
Change from base Build 177: 1.9%
Covered Lines: 2189
Relevant Lines: 3561
💛 - Coveralls

mgjm
mgjm commented Jun 27, 2019
View reviewed changes
packages/MusicNotation-Core.package/MNPitch.class/class/readFrom..st Outdated Show resolved Hide resolved
packages/MusicNotation-Scripting.package/MNNoteBuilder.class/class/context.pitch..st Outdated Show resolved Hide resolved
packages/MusicNotation-Scripting.package/MNNoteBuilder.class/instance/^plus.st Outdated Show resolved Hide resolved
packages/MusicNotation-Core.package/MNPitch.class/instance/setFlat.st Outdated Show resolved Hide resolved
packages/MusicNotation-Core.package/MNPitch.class/instance/setNatural.st Outdated Show resolved Hide resolved
packages/MusicNotation-Scripting.package/MNNoteBuilder.class/class/context.pitch..st Outdated Show resolved Hide resolved
packages/MusicNotation-Scripting.package/MNNoteBuilder.class/instance/pitchesDo..st Outdated Show resolved Hide resolved
packages/MusicNotation-Scripting.package/MNNoteBuilder.class/instance/createNote..st Outdated Show resolved Hide resolved
packages/MusicNotation-Scripting.package/MNNoteBuilder.class/instance/n.st Outdated Show resolved Hide resolved
packages/MusicNotation-Scripting.package/MNNoteBuilder.class/instance/s.st Outdated Show resolved Hide resolved
@mgjm
Copy link
Contributor Author

mgjm commented Jun 28, 2019

LGTM

@underFlo underFlo marked this pull request as ready for review June 28, 2019 10:20
@underFlo underFlo merged commit 979398b into master Jun 28, 2019
@underFlo underFlo deleted the notebuilder branch June 28, 2019 10:20
@mayer-maximilian mayer-maximilian changed the title Multiple Pitches - Scripting Adds multiple pitches for scripting Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underFlo underFlo underFlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgjm @coveralls @underFlo