Changed the review annotations

hpi-swa-teaching · Jun 13, 2018 · 1943d46 · 1943d46
1 parent 464cf31
commit 1943d46
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 11 deletions.
diff --git a/...Pack.package/RPTestApp.class/instance/handleRequestForCaptureGroupsWithNumber.andWord..st b/...Pack.package/RPTestApp.class/instance/handleRequestForCaptureGroupsWithNumber.andWord..st
@@ -1,6 +1,6 @@
 routes
 handleRequestForCaptureGroupsWithNumber: aNumber andWord: aWord
-	<get: '/captureGroups/number/([\d]+)/word/([\w]+)'>
+	<get: '/captureGroups/number/(\d+)/word/(\w+)'>
 
 	self dynamicEnvironment at: #number put: aNumber asNumber.
 	self dynamicEnvironment at: #word put: aWord.
diff --git a/packages/RatPack.package/RPTestApp.class/instance/handleRequestForManySlashes.st b/packages/RatPack.package/RPTestApp.class/instance/handleRequestForManySlashes.st
@@ -1,4 +1,4 @@
 routes
 handleRequestForManySlashes
-	<get: '/thisDoesExist/butDontTakeArguments/even/with/many/Slashes'>
+	<get: '/thisDoesExist/butDoesntTakeArguments/even/with/many/Slashes'>
 
diff --git a/packages/RatPack.package/RPTestApp.class/methodProperties.json b/packages/RatPack.package/RPTestApp.class/methodProperties.json
@@ -6,10 +6,10 @@
 	"instance" : {
 		"blacklistedHandler" : "lj 5/25/2018 19:40",
 		"handleRequestForAutoGlobalMiddleware" : "lj 5/30/2018 14:31",
-		"handleRequestForCaptureGroupsWithNumber:andWord:" : "lj 6/13/2018 14:16",
+		"handleRequestForCaptureGroupsWithNumber:andWord:" : "lj 6/13/2018 17:42",
 		"handleRequestForChainOrder" : "lj 5/25/2018 20:58",
 		"handleRequestForIndex" : "lj 6/12/2018 17:00",
-		"handleRequestForManySlashes" : "lj 6/13/2018 14:41",
+		"handleRequestForManySlashes" : "lj 6/13/2018 17:43",
 		"handleRequestForRedirect" : "LB 5/11/2015 11:15",
 		"handleRequestForSetHeaders" : "lj 6/6/2018 15:05",
 		"handleRequestForSimpleJSON" : "jm 5/9/2018 13:09",

diff --git a/packages/RatPack.package/RPTests.class/instance/testCaptureGroups.st b/packages/RatPack.package/RPTests.class/instance/testCaptureGroups.st
@@ -1,6 +1,6 @@
 test - routing
 testCaptureGroups
 
-	RPTestHelper get: '/captureGroups/number/1/word/Test' on: app.
-	self assert: (app dynamicEnvironment at: #number) equals: 1.
+	RPTestHelper get: '/captureGroups/number/123456789/word/Test' on: app.
+	self assert: (app dynamicEnvironment at: #number) equals: 123456789.
 	self assert: (app dynamicEnvironment at: #word) equals: 'Test'.
diff --git a/packages/RatPack.package/RPTests.class/instance/testManySlashes.st b/packages/RatPack.package/RPTests.class/instance/testManySlashes.st
@@ -4,5 +4,5 @@ testManySlashes
 	RPTestHelper get: '/thisDoesNotExist/even/with/many/Slashes' on: app.
 	self assert: app response status = #notFound.
 
-	RPTestHelper get: '/thisDoesExist/butDontTakeArguments/even/with/many/Slashes' on: app.
+	RPTestHelper get: '/thisDoesExist/butDoesntTakeArguments/even/with/many/Slashes' on: app.
 	self assert: app response status = #ok.
diff --git a/packages/RatPack.package/RPTests.class/instance/testNotFound.st b/packages/RatPack.package/RPTests.class/instance/testNotFound.st
@@ -6,5 +6,5 @@ testNotFound
 	self assert: result status = #notFound.
 	self assert: result contentType = 'text/html'.
 
-	RPTestHelper get: '/thisDoesNotExist/(.*)/andCaptureGroupsInURLDontMakeProblem' on: app.
+	RPTestHelper get: '/thisDoesNotExist/(.*)/andCaptureGroupsInUrl/AreNoProblem' on: app.
 	self assert: app response status = #notFound.
diff --git a/packages/RatPack.package/RPTests.class/methodProperties.json b/packages/RatPack.package/RPTests.class/methodProperties.json
@@ -5,7 +5,7 @@
 		"setUp" : "re 5/9/2018 13:32",
 		"tearDown" : "mm 7/14/2015 21:38",
 		"testAddObject" : "LB 7/15/2015 20:06",
-		"testCaptureGroups" : "lj 6/13/2018 14:46",
+		"testCaptureGroups" : "lj 6/13/2018 17:44",
 		"testConvertModelClassToSQLString" : "LB 7/12/2015 21:31",
 		"testCorrectContentDecoding" : "re 5/9/2018 15:03",
 		"testCreateTableWithExternalDatabase" : "LB 7/12/2015 22:27",
@@ -22,15 +22,15 @@
 		"testInvalidContentDecoding" : "re 5/9/2018 13:17",
 		"testJsonDecoder" : "re 5/15/2018 11:15",
 		"testLoadObjectsOnExternalDatabase" : "MF 7/14/2015 15:30",
-		"testManySlashes" : "lj 6/13/2018 14:41",
+		"testManySlashes" : "lj 6/13/2018 17:43",
 		"testMiddlewareAutoglobalMiddleware" : "lj 5/30/2018 14:47",
 		"testMiddlewareBlacklist" : "lj 5/25/2018 19:50",
 		"testMiddlewareCallChainInterrupt" : "lj 5/25/2018 20:59",
 		"testMiddlewareCallChainOrder" : "lj 5/25/2018 19:04",
 		"testMiddlewareInstanciation" : "lj 5/22/2018 15:14",
 		"testMiddlewarePreHookFalse" : "lj 5/30/2018 15:02",
 		"testMiddlewarePreHookTrue" : "lj 5/30/2018 15:02",
-		"testNotFound" : "lj 6/13/2018 14:47",
+		"testNotFound" : "lj 6/13/2018 17:46",
 		"testObjectIndexing" : "LB 7/15/2015 19:48",
 		"testPost" : "lj 5/23/2018 18:21",
 		"testPostReturningNewObject" : "lj 5/16/2018 14:58",