Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to ignore words #37

Merged
merged 7 commits into from
Jun 14, 2018
Merged

Ability to ignore words #37

merged 7 commits into from
Jun 14, 2018

Conversation

youri-k
Copy link
Contributor

@youri-k youri-k commented Jun 10, 2018 •
edited
Loading

  • plus rename ignore all to skip all to clarify its meaning

@youri-k youri-k self-assigned this Jun 10, 2018
@coveralls
Copy link

coveralls commented Jun 10, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 187

  • 17 of 17 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 85.237%
Totals Coverage Status
Change from base Build 172: 0.4%
Covered Lines: 485
Relevant Lines: 569
💛 - Coveralls

rschwanhold
rschwanhold approved these changes Jun 11, 2018
View reviewed changes
Copy link
Contributor

@rschwanhold rschwanhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Maybe it would be a benitif to 'ignore all' words but the way you've done it is ok for me.

@odanivan
Copy link
Contributor

So what exactly does "skip all" do? And why don't we have a "ignore all" button?

@youri-k youri-k merged commit 123ac8c into master Jun 14, 2018
@youri-k youri-k mentioned this pull request Jun 14, 2018
Merged
@rschwanhold rschwanhold deleted the ignore-words branch June 27, 2018 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschwanhold rschwanhold rschwanhold approved these changes

@odanivan odanivan odanivan approved these changes

Assignees

@youri-k youri-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wörter ignorieren können
4 participants
@youri-k @coveralls @odanivan @rschwanhold