Apply review suggestions

hpi-swa-teaching · Jun 2, 2021 · cbf1da9 · cbf1da9
1 parent 9c12353
commit cbf1da9
Show file tree

Hide file tree

Showing 9 changed files with 20 additions and 10 deletions.
diff --git a/packages/SketchMorph2-Core.package/M2Backend.class/instance/commitText.st b/packages/SketchMorph2-Core.package/M2Backend.class/instance/commitText.st
@@ -5,7 +5,7 @@ commitText
 	point := self temporaryTextMorph position - (self temporaryTextMorph owner
 		ifNotNil: [self temporaryTextMorph owner position]
 		ifNil: [0]).
-	self temporaryTextMorph selectFrom: 0 to: 0.
+	self temporaryTextMorph selectAt: 0.
 	self temporaryTextMorph contents ifNotEmpty: [
 		self 
 			createTextUserActionWith: self temporaryTextMorph at: point;

diff --git a/packages/SketchMorph2-Core.package/M2Backend.class/instance/startEditingTextAt..st b/packages/SketchMorph2-Core.package/M2Backend.class/instance/startEditingTextAt..st
@@ -4,5 +4,5 @@ startEditingTextAt: aPoint
 	point := aPoint + (self temporaryTextMorph canvas
 		ifNotNil: [self temporaryTextMorph canvas position]
 		ifNil: [0]).
-	self temporaryTextMorph getAt: point.
+	self temporaryTextMorph moveTo: point.
 	self mode: #editingText
diff --git a/packages/SketchMorph2-Core.package/M2Backend.class/methodProperties.json b/packages/SketchMorph2-Core.package/M2Backend.class/methodProperties.json
@@ -13,7 +13,7 @@
 		"clearCanvas" : "JP 5/31/2021 19:09",
 		"clearCanvasAndPushUndoLevel" : "mk 7/27/2020 20:29",
 		"clickAt:" : "CS 6/2/2021 11:56",
-		"commitText" : "CS 6/2/2021 20:20",
+		"commitText" : "CS 6/2/2021 21:26",
 		"copyForm" : "mk 7/27/2020 19:49",
 		"createTextUserActionWith:at:" : "JP 6/2/2021 18:33",
 		"createUserActionWithStart:" : "NC 8/5/2020 18:34",
@@ -107,7 +107,7 @@
 		"sourceForm:" : "CCJ 6/15/2020 15:34",
 		"startDrawing" : "mFr 5/5/2021 16:45",
 		"startDrawingAt:" : "NC 7/24/2020 12:23",
-		"startEditingTextAt:" : "CS 6/2/2021 15:28",
+		"startEditingTextAt:" : "CS 6/2/2021 21:28",
 		"startPoint" : "mp 5/17/2020 11:57",
 		"startPoint:" : "NC 5/16/2020 11:35",
 		"stopDrawing" : "NC 7/24/2020 12:23",

diff --git a/packages/SketchMorph2-Core.package/M2TemporaryTextMorph.class/instance/dismissCurrent.st b/packages/SketchMorph2-Core.package/M2TemporaryTextMorph.class/instance/dismissCurrent.st
@@ -1,7 +1,7 @@
 interaction
 dismissCurrent
 	self canvas ifNotNil: [self canvas removeMorph: self].
-	ActiveHand newKeyboardFocus: nil.
+	self activeHand newKeyboardFocus: nil.
 	self
 		contents: '';
 		morphExists: false
diff --git a/...mporaryTextMorph.class/instance/getAt..st → ...poraryTextMorph.class/instance/moveTo..st b/...mporaryTextMorph.class/instance/getAt..st → ...poraryTextMorph.class/instance/moveTo..st
@@ -1,6 +1,6 @@
 interaction
-getAt: aPoint
+moveTo: aPoint
 	self position: aPoint.
 	self canvas ifNotNil: [self canvas addMorph: self].
-	ActiveHand newKeyboardFocus: self.
+	self activeHand newKeyboardFocus: self.
 	self morphExists: true
diff --git a/packages/SketchMorph2-Core.package/M2TemporaryTextMorph.class/methodProperties.json b/packages/SketchMorph2-Core.package/M2TemporaryTextMorph.class/methodProperties.json
@@ -5,8 +5,8 @@
 		"canvas" : "CS 6/2/2021 12:08",
 		"canvas:" : "CS 6/2/2021 12:08",
 		"defaultFont" : "CS 6/2/2021 12:11",
-		"dismissCurrent" : "JP 6/2/2021 18:38",
-		"getAt:" : "CS 6/2/2021 15:27",
+		"dismissCurrent" : "CS 6/2/2021 21:22",
 		"initialize" : "CS 6/2/2021 15:13",
 		"morphExists" : "CS 6/2/2021 15:11",
-		"morphExists:" : "CS 6/2/2021 15:06" } }
+		"morphExists:" : "CS 6/2/2021 15:06",
+		"moveTo:" : "CS 6/2/2021 21:28" } }
diff --git a/packages/SketchMorph2-Core.package/TextMorph.extension/instance/selectAt..st b/packages/SketchMorph2-Core.package/TextMorph.extension/instance/selectAt..st
@@ -0,0 +1,3 @@
+*SketchMorph2-Core
+selectAt: characterIndex
+	self editor selectAt: characterIndex
diff --git a/packages/SketchMorph2-Core.package/TextMorph.extension/methodProperties.json b/packages/SketchMorph2-Core.package/TextMorph.extension/methodProperties.json
@@ -0,0 +1,5 @@
+{
+	"class" : {
+		 },
+	"instance" : {
+		"selectAt:" : "CS 6/2/2021 21:26" } }
diff --git a/packages/SketchMorph2-Core.package/TextMorph.extension/properties.json b/packages/SketchMorph2-Core.package/TextMorph.extension/properties.json
@@ -0,0 +1,2 @@
+{
+	"name" : "TextMorph" }