Refactor and reduce tests

Remove obsolete method Co-authored-by: Benedikt Schenkel <benedikt.schenkel@student.hpi.de>
hpi-swa-teaching · Jun 19, 2019 · e67b56c · e67b56c
1 parent 3a9365a
commit e67b56c
Show file tree

Hide file tree

Showing 27 changed files with 20 additions and 158 deletions.
diff --git a/packages/SpreadSheetTool-Core.package/SSSheet.class/class/newSheet.st b/packages/SpreadSheetTool-Core.package/SSSheet.class/class/newSheet.st
diff --git a/packages/SpreadSheetTool-Core.package/SSSheet.class/methodProperties.json b/packages/SpreadSheetTool-Core.package/SSSheet.class/methodProperties.json
@@ -1,7 +1,6 @@
 {
 	"class" : {
-		"cellFactory:rowHeaderFactory:columnHeaderFactory:" : "CT 5/28/2019 18:09",
-		"newSheet" : "CT 6/13/2019 13:16" },
+		"cellFactory:rowHeaderFactory:columnHeaderFactory:" : "CT 5/28/2019 18:09" },
 	"instance" : {
 		"allContents" : "CT 6/7/2019 13:32",
 		"anySatisfy:" : "CT 5/29/2019 14:56",

diff --git a/packages/SpreadSheetTool-Tests.package/Collection.extension/instance/cross.collect..st b/packages/SpreadSheetTool-Tests.package/Collection.extension/instance/cross.collect..st
@@ -0,0 +1,8 @@
+*SpreadSheetTool-Tests-enumerating
+cross: aCollection collect: aBlock
+
+	| combinationCollections |
+	combinationCollections := self collect: [:first |
+		aCollection collect: [:second |
+			aBlock value: first value: second]].
+	^ combinationCollections reduce: #,
diff --git a/packages/SpreadSheetTool-Tests.package/Collection.extension/methodProperties.json b/packages/SpreadSheetTool-Tests.package/Collection.extension/methodProperties.json
@@ -0,0 +1,5 @@
+{
+	"class" : {
+		 },
+	"instance" : {
+		"cross:collect:" : "CT 6/19/2019 11:40" } }
diff --git a/packages/SpreadSheetTool-Tests.package/Collection.extension/properties.json b/packages/SpreadSheetTool-Tests.package/Collection.extension/properties.json
@@ -0,0 +1,2 @@
+{
+	"name" : "Collection" }
diff --git a/packages/SpreadSheetTool-Tests.package/SSHeaderTest.class/instance/someValue.st b/packages/SpreadSheetTool-Tests.package/SSHeaderTest.class/instance/someValue.st
@@ -1,4 +1,4 @@
 testing data
 someValue
 
-	^ 'World spreadSheets maxByBeautiness = SqueakSheet'
+	^ 'Squeak forever <3'
diff --git a/packages/SpreadSheetTool-Tests.package/SSHeaderTest.class/methodProperties.json b/packages/SpreadSheetTool-Tests.package/SSHeaderTest.class/methodProperties.json
@@ -5,7 +5,7 @@
 		"classUnderTest" : "CT 5/29/2019 15:28",
 		"fixturesForLabel" : "CT 6/6/2019 10:45",
 		"setUp" : "CT 6/7/2019 14:00",
-		"someValue" : "CT 5/29/2019 15:52",
+		"someValue" : "CT 6/19/2019 11:43",
 		"testColumnHeaderFor" : "CT 5/29/2019 15:29",
 		"testGenerateColumnLabelFor" : "CT 5/29/2019 15:28",
 		"testGenerateRowLabelFor" : "CT 5/29/2019 15:28",

diff --git a/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/README.md b/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/README.md
diff --git a/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/classUnderTest.st b/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/classUnderTest.st
diff --git a/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/columnCount..st b/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/columnCount..st
diff --git a/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/columnCount.st b/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/columnCount.st
diff --git a/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/rowCount..st b/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/rowCount..st
diff --git a/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/rowCount.st b/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/rowCount.st
diff --git a/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/setUp.st b/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/setUp.st
diff --git a/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/someColumnIndex.st b/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/someColumnIndex.st
diff --git a/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/someLabel.st b/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/someLabel.st
diff --git a/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/someRowIndex.st b/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/someRowIndex.st
diff --git a/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/someValue.st b/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/someValue.st
diff --git a/...ges/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/testCellStoresValue.st b/...ges/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/testCellStoresValue.st
diff --git a/...adSheetTool-Tests.package/SSSheetSystemTest.class/instance/testColumnHeaderStoresLabel.st b/...adSheetTool-Tests.package/SSSheetSystemTest.class/instance/testColumnHeaderStoresLabel.st
diff --git a/...ts.package/SSSheetSystemTest.class/instance/testConstructedSheetHasSpecifiedDimensions.st b/...ts.package/SSSheetSystemTest.class/instance/testConstructedSheetHasSpecifiedDimensions.st
diff --git a/...SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/testRowCountColumnCount.st b/...SpreadSheetTool-Tests.package/SSSheetSystemTest.class/instance/testRowCountColumnCount.st
diff --git a/...preadSheetTool-Tests.package/SSSheetSystemTest.class/instance/testRowHeaderStoresLabel.st b/...preadSheetTool-Tests.package/SSSheetSystemTest.class/instance/testRowHeaderStoresLabel.st
diff --git a/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/methodProperties.json b/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/methodProperties.json
diff --git a/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/properties.json b/packages/SpreadSheetTool-Tests.package/SSSheetSystemTest.class/properties.json
diff --git a/...preadSheetTool-Tests.package/SSSheetTest.class/instance/fixturesForRowCountColumnCount.st b/...preadSheetTool-Tests.package/SSSheetTest.class/instance/fixturesForRowCountColumnCount.st
@@ -10,7 +10,4 @@ fixturesForRowCountColumnCount
 		self someColumnIndex.
 		self columnCount.
 		self columnCount + self someColumnIndex }.
-	^ (rows collect: [:row |
-		columns collect: [:column |
-			{ row. column }]])
-		reduce: #,
+	^ rows cross: columns collect: [:row :column | {row. column}]
diff --git a/packages/SpreadSheetTool-Tests.package/SSSheetTest.class/methodProperties.json b/packages/SpreadSheetTool-Tests.package/SSSheetTest.class/methodProperties.json
@@ -6,7 +6,7 @@
 		"classUnderTest" : "CT 6/7/2019 12:45",
 		"columnCount" : "CT 4/30/2019 12:03",
 		"columnHeaderFor:" : "CT 5/28/2019 18:56",
-		"fixturesForRowCountColumnCount" : "CT 5/29/2019 15:14",
+		"fixturesForRowCountColumnCount" : "CT 6/19/2019 11:37",
 		"rowCount" : "CT 4/30/2019 15:28",
 		"rowHeaderFor:" : "CT 5/28/2019 18:56",
 		"setUp" : "CT 6/7/2019 13:16",