Improve Test Coverage

hpi-swa-teaching · Jul 21, 2022 · dd9be3a · dd9be3a
1 parent f267b4d
commit dd9be3a
Show file tree

Hide file tree

Showing 8 changed files with 32 additions and 7 deletions.
diff --git a/packages/TelegramClient-UI.package/TCUAddMembersMessage.class/instance/initialize.st b/packages/TelegramClient-UI.package/TCUAddMembersMessage.class/instance/initialize.st
@@ -5,6 +5,7 @@ initialize
 	super initialize.
 
 	textMorph := (TextMorph new
+		lock;
 		contents: self messageModel asText;
 		color: Color white;
 		left: self class defaultLayoutInset;

diff --git a/packages/TelegramClient-UI.package/TCUAddMembersMessage.class/methodProperties.json b/packages/TelegramClient-UI.package/TCUAddMembersMessage.class/methodProperties.json
@@ -3,4 +3,4 @@
 		"defaultBorderWidth" : "rgw 7/21/2022 15:38",
 		"defaultLayoutInset" : "rgw 7/21/2022 14:52" },
 	"instance" : {
-		"initialize" : "rgw 7/21/2022 15:39" } }
+		"initialize" : "rgw 7/21/2022 15:54" } }
diff --git a/...kage/TCTCMessageTests.class/instance/testMessageAddMembersCorrectlyConstructedFromJson.st b/...kage/TCTCMessageTests.class/instance/testMessageAddMembersCorrectlyConstructedFromJson.st
@@ -4,7 +4,9 @@ testMessageAddMembersCorrectlyConstructedFromJson
 	| chat addMembersEvent addMembersMessage |
 
  	chat := TCTMMocks mockBasicGroupChat.
-	addMembersEvent := TCTMMocks mockMessageAddMembersFrom: {TCTMMocks mockUser2 id} to: chat id.
+	addMembersEvent := TCTMMocks mockMessageAddMembersFrom: {TCTMMocks mockUser1 id} to: chat id.
 	addMembersMessage := TCCUserMessage newFromMessageEvent: addMembersEvent in: chat with: self core.
 
-	self assert: addMembersMessage members equals: {TCTMMocks mockUser2 id}
+	self assert: addMembersMessage members equals: {TCTMMocks mockUser1 id}.
+	self assert: 'Added: Test User' equals: addMembersMessage asSnippet.
+	self assert: 'Added: Test User' equals: addMembersMessage asText
diff --git a/packages/TelegramClientTests-Core.package/TCTCMessageTests.class/methodProperties.json b/packages/TelegramClientTests-Core.package/TCTCMessageTests.class/methodProperties.json
@@ -2,7 +2,7 @@
 	"class" : {
 		 },
 	"instance" : {
-		"testMessageAddMembersCorrectlyConstructedFromJson" : "rgw 7/21/2022 15:41",
+		"testMessageAddMembersCorrectlyConstructedFromJson" : "rgw 7/21/2022 16:04",
 		"testMessageCorrectlyConstructedFromJson" : "aka 7/14/2022 16:58",
 		"testMessageHasTextRepresentation" : "tom.richter 6/26/2021 21:06",
 		"testMessageIsReply" : "rgw 5/12/2022 16:40",

diff --git a/...s/TelegramClientTests-UI.package/TCTUMessageTests.class/instance/testAddMembersMessage.st b/...s/TelegramClientTests-UI.package/TCTUMessageTests.class/instance/testAddMembersMessage.st
@@ -8,4 +8,4 @@ testAddMembersMessage
 	addMembersMessage := TCCUserMessage newFromMessageEvent: addMembersEvent in: chat with: self core.
 
 	self wantsToTest: (TCUMessage newFrom: addMembersMessage).
-	self assertReading: 'Added: Test User' in: self subject.
+	self assertReading: 'Added: Test User' in: self subject
diff --git a/...Tests-UI.package/TCTUMessageTests.class/instance/testAddMembersMessageIsNotUserMessage.st b/...Tests-UI.package/TCTUMessageTests.class/instance/testAddMembersMessageIsNotUserMessage.st
@@ -0,0 +1,11 @@
+testing
+testAddMembersMessageIsNotUserMessage
+
+	| addMembersEvent addMembersMessage chat |
+
+ 	chat := TCTMMocks mockBasicGroupChat.
+	addMembersEvent := TCTMMocks mockMessageAddMembersFrom: {TCTMMocks mockUser1 id} to: chat id.
+	addMembersMessage := TCCUserMessage newFromMessageEvent: addMembersEvent in: chat with: self core.
+
+	self wantsToTest: (TCUMessage newFrom: addMembersMessage).
+	self deny: self subject isUserMessage
diff --git a/...ramClientTests-UI.package/TCTUMessageTests.class/instance/testTextMessageIsUserMessage.st b/...ramClientTests-UI.package/TCTUMessageTests.class/instance/testTextMessageIsUserMessage.st
@@ -0,0 +1,9 @@
+testing
+testTextMessageIsUserMessage
+
+	| message |
+
+	message := (TCTMMocks mockTextMessageWith: self core).
+
+	self wantsToTest: (TCUMessage newFrom: message).
+	self assert: self subject isUserMessage
diff --git a/packages/TelegramClientTests-UI.package/TCTUMessageTests.class/methodProperties.json b/packages/TelegramClientTests-UI.package/TCTUMessageTests.class/methodProperties.json
@@ -5,7 +5,8 @@
 		"expectedSqueak5_2Failures" : "pk 7/6/2021 12:25",
 		"handleScreenShotTestFor:with:usedBy:" : "RK 6/26/2021 10:15",
 		"setUp" : "rgw 6/6/2022 18:42",
-		"testAddMembersMessage" : "rgw 7/21/2022 15:27",
+		"testAddMembersMessage" : "rgw 7/21/2022 16:02",
+		"testAddMembersMessageIsNotUserMessage" : "rgw 7/21/2022 16:01",
 		"testMessageBetweenRequestsAnsweredMessage" : "LR 5/29/2022 17:34",
 		"testMessageColorsDifferentForIncomingOutgoing" : "tom.richter 6/26/2021 17:23",
 		"testMessageContainsDate" : "tom.richter 6/26/2021 17:23",
@@ -18,4 +19,5 @@
 		"testTextAndPhotoScaleCorrectlyLongCaption" : "JS 5/27/2022 19:40",
 		"testTextAndPhotoScaleCorrectlyLongUserName" : "JS 5/27/2022 19:40",
 		"testTextAndPhotoScaleCorrectlyNoCaption" : "JS 5/27/2022 19:40",
-		"testTextAndPhotoScaleCorrectlyShortCaption" : "JS 5/27/2022 19:40" } }
+		"testTextAndPhotoScaleCorrectlyShortCaption" : "JS 5/27/2022 19:40",
+		"testTextMessageIsUserMessage" : "rgw 7/21/2022 15:58" } }