Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$BASELINE is not defined #19

Closed
peteruhnak opened this issue Dec 18, 2015 · 2 comments
Closed

$BASELINE is not defined #19

peteruhnak opened this issue Dec 18, 2015 · 2 comments

Comments

@peteruhnak
Copy link
Contributor

Somewhere in the last 9 days something has changed that breaks builds because of a missing baseline.

Here's an example of broken build https://travis-ci.org/dynacase/class-editor/builds/95859363
Notice that just couple of lines above the error is export BASELINE="DCUmlClassEditor" so I call shenanigans.

The same code with same travis configuration was passing ~9 days ago https://travis-ci.org/dynacase/class-editor/builds/95670552 (the broken build is just a rerun)

What is missing? Looking at the readme this hasn't changed.

@peteruhnak peteruhnak changed the title $BASELINE is not defined. $BASELINE is not defined Dec 18, 2015
@fniephaus
Copy link
Member

Travis has just merged some code that allows us to define the baseline like this:

language: smalltalk
smalltalk:
  - Pharo-stable
baseline: MyProject
...

Unfortunately, it seems that this change is not backwards-compatible.
Sorry about that, we didn't know that this would happen and it probably takes too long to make it compatible.

I will update the README and add a notice to the script to inform users about the change.

fniephaus added a commit that referenced this issue Dec 18, 2015
@peteruhnak
Copy link
Contributor Author

Ah so just not updated readme. I like the new option 👍

fniephaus added a commit that referenced this issue Dec 18, 2015
fniephaus added a commit that referenced this issue Dec 20, 2015
Workaround for baseline incompatibility

Debug
fniephaus added a commit that referenced this issue Dec 31, 2015
This reverts commit 0ad7549.

Reverted to avoid confusion. We are currently discussing a new way to configure Smalltalk builds:
#20

And we are not sure if we will keep `baseline: ...` where it currently is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants