Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cuis Smalltalk package fileIn broken #123

Closed
KenDickey opened this issue Jun 24, 2020 · 13 comments
Closed

Cuis Smalltalk package fileIn broken #123

KenDickey opened this issue Jun 24, 2020 · 13 comments
Assignees
@fniephaus
Labels
crash

Comments

@KenDickey
Copy link

looks like #become:

cuis-fileIn-backtrace.txt

Current Cuis Smalltalk (Linux/Amd64)
FileList package fileIn
@fniephaus
Copy link
Member

Indeed...thanks for the report, Ken! I'll have a look.

@fniephaus fniephaus self-assigned this Jun 24, 2020
@KenDickey
Copy link
Author

KenDickey commented Jun 25, 2020 via email

@fniephaus
Copy link
Member

Thanks a lot, Ken! I should give aarch64 a go soon.

How do I reproduce this issue? I thought I had to run FileList package fileIn, but that's not it. What did you run to trigger the crash? I have a fix, but would like to validate before pushing it.

@fniephaus
Copy link
Member

A fix is now in place and will ship with the next release.

BTW: I managed to run Cuis with TruffleSqueak on aarch64. Now I only need to figure out how we can build TruffleSqueak for aarch64 on our CI infrastructure.

@KenDickey
Copy link
Author

KenDickey commented Jun 25, 2020 via email

@KenDickey
Copy link
Author

KenDickey commented Jun 25, 2020 via email

@fniephaus
Copy link
Member

World Menu -> Changes.. -> Install New Updates

Seems to work now:
image

I'm afraid gu -C gu-catalog.properties update smalltalk will only give you the latest release, and we don't push a new release on each commit. So that means you'd need to build TruffleSqueak from master. Let me try to explain this in short for Java11 (but it should really be documented soon):

mkdir trufflesqueak-build
cd trufflesqueak-build
git clone https://github.com/graalvm/mx
git clone https://github.com/hpi-swa/trufflesqueak
cd trufflesqueak
../mx/mx --env trufflesqueak-jvm build --dependencies=SMALLTALK_INSTALLABLE_JAVA11
gu install -f -L "$(mx --env trufflesqueak-jvm paths SMALLTALK_INSTALLABLE_JAVA11)"

mx will checkout the graal repository, that's why I'd recommend using a dedicated top directory (trufflesqueak-build in the example above).

@KenDickey
Copy link
Author

KenDickey commented Jun 26, 2020 via email

@fniephaus
Copy link
Member

Hi Ken,
Please run this one first and make sure it works: ../mx/mx build.
Could not find 'sdk:GRAAL_SDK' in GraalVM suggests that the graal dependency was not built, it looks like it's not even checked out (because ls only lists mx and trufflesqueak, there should also be a graal directory).
Once mx build succeeds, you should be able to build the component (and you don't have to run mx build anymore).

Do I need a symlink to which trufflesqueak or some such?

No, the component is a jar file, which you can then install using the gu utility. That will create or update the bin/trufflesqueak in your GraalVM installation.

@KenDickey
Copy link
Author

KenDickey commented Jun 26, 2020 via email

@fniephaus
Copy link
Member

Looks like it tries to rebuild the world .. and fails. (attached)

Probably not worth your time to debug this process remotely.

It seems you're trying to build with GraalVM, but I'm afraid it can't bootstrap itself. So either use your system Java11 or this one: https://github.com/graalvm/labs-openjdk-11/releases/download/jvmci-20.1-b02/labsjdk-ce-11.0.7+10-jvmci-20.1-b02-linux-amd64.tar.gz

If you let me know when you do the next release I can test then. I am
especially interested in Aarch64 Cuis.

You can watch this repository for "Releases only". Just click on the "watch" button next to the "star" and "fork" buttons, and you'll receive an email notification whenever we push a release.

Cheers,
Fabio

Thanks again for all,
-KenD

@KenDickey
Copy link
Author

KenDickey commented Jun 27, 2020 via email

@fniephaus
Copy link
Member

What are the hidden semantics of "use your system Java11" ?

It usually should just work out of the box, did you set JAVA_HOME=/home/kend/Downloads/GraalSqueak/graalvm-ce-java11-20.1.0 somewhere? It should be JAVA_HOME=/usr/lib/jvm/openjdk-11-jdk on your system I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fniephaus fniephaus

Labels
crash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fniephaus @KenDickey