Fix(Notifications): Better flash messages

hpi-swt2 · Mar 25, 2019 · 71fd00f · 71fd00f
1 parent 2f4bd89
commit 71fd00f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/app/controllers/notifications_controller.rb b/app/controllers/notifications_controller.rb
@@ -11,9 +11,9 @@ def index
   # DELETE /notifications/1
   def destroy
     if @notification.destroy
-      notice = 'Notification was successfully deleted.'
+      notice = "Notification '#{@notification.title}' was successfully deleted."
     else
-      alert = 'Error while deleting notification.'
+      alert = "Error while deleting notification '#{@notification.title}'."
     end
     redirect_back fallback_location: notifications_path, notice: notice, alert: alert
   end
@@ -34,7 +34,7 @@ def mark_as_read
     if @notification.save
       redirect_back fallback_location: notifications_path
     else
-      redirect_back fallback_location: notifications_path, alert: 'Something went wrong.'
+      redirect_back fallback_location: notifications_path, alert: 'Error while marking notifcation as read.'
     end
   end
 

diff --git a/app/views/notifications/index.html.erb b/app/views/notifications/index.html.erb
@@ -1,5 +1,3 @@
-<p id="notice"><%= notice %></p>
-
 <h1>Notifications</h1>
 
 <%= render 'list' %>