Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

426/Let users be selected without domains #435

Merged
merged 5 commits into from Mar 6, 2019
Merged

426/Let users be selected without domains #435

merged 5 commits into from Mar 6, 2019

Conversation

bdaase
Copy link
Contributor

@bdaase bdaase commented Feb 27, 2019

Fixes #426

@chrisma
Copy link
Contributor

chrisma commented Mar 5, 2019

human_readable_identifier is implemented in app/models/user.rb

chrisma
chrisma approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@chrisma chrisma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@LeonMatthes LeonMatthes merged commit 41c4a09 into dev Mar 6, 2019
@LeonMatthes LeonMatthes deleted the 426/userNamesWithoutDomains branch March 6, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisma chrisma chrisma approved these changes

@LeonMatthes LeonMatthes Awaiting requested review from LeonMatthes

@rteusner rteusner Awaiting requested review from rteusner

@krichly krichly Awaiting requested review from krichly

@BraunTom BraunTom Awaiting requested review from BraunTom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bdaase @chrisma @LeonMatthes