Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster loading of dashboard and vms/index page #517

Merged
merged 18 commits into from
Apr 12, 2019
Merged

Faster loading of dashboard and vms/index page #517

merged 18 commits into from
Apr 12, 2019

Conversation

BraunTom
Copy link
Contributor

No description provided.

@BraunTom BraunTom added the WIP work is still in progess for this PR label Mar 25, 2019
chrisma
chrisma reviewed Apr 1, 2019
View reviewed changes
Gemfile Show resolved Hide resolved
chrisma
chrisma requested changes Apr 4, 2019
View reviewed changes
app/api/v_sphere/folder.rb Outdated Show resolved Hide resolved
@BraunTom BraunTom added Review Required and removed WIP work is still in progess for this PR labels Apr 7, 2019
bdaase
bdaase reviewed Apr 8, 2019
View reviewed changes
Gemfile Show resolved Hide resolved
bdaase
bdaase reviewed Apr 8, 2019
View reviewed changes
db/schema.rb Show resolved Hide resolved
LeonMatthes
LeonMatthes requested changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@LeonMatthes LeonMatthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the cache whenever it is empty.
The rest looks very good though

app/api/v_sphere/folder.rb Outdated Show resolved Hide resolved
app/api/v_sphere/virtual_machine.rb Show resolved Hide resolved
app/api/v_sphere/virtual_machine.rb Show resolved Hide resolved
app/helpers/vms_helper.rb Show resolved Hide resolved
@BraunTom BraunTom merged commit 7f38f15 into dev Apr 12, 2019
@BraunTom BraunTom deleted the performance branch April 12, 2019 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdaase bdaase bdaase left review comments

@LeonMatthes LeonMatthes LeonMatthes approved these changes

@chrisma chrisma Awaiting requested review from chrisma

@rteusner rteusner Awaiting requested review from rteusner

@krichly krichly Awaiting requested review from krichly

Assignees
No one assigned
Labels
Review Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BraunTom @LeonMatthes @chrisma @bdaase