Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US_3.25: Application canceled state #242

Closed
22 of 30 tasks
tobiasduerschmid opened this issue Jan 5, 2017 · 1 comment
Closed
22 of 30 tasks

US_3.25: Application canceled state #242

tobiasduerschmid opened this issue Jan 5, 2017 · 1 comment

Comments

@tobiasduerschmid
Copy link
Contributor

tobiasduerschmid commented Jan 5, 2017

As
organizer

I want to
change participants application state to canceled

in order to
be able to choose an alternative applicant who was rejected.

Tasks

New state:

  • new canceled + pre_accepted state

  • refactor code accordingly

  • add pre_accepted application_letter factory

  • rewrite (accepted/rejected)_applications_count

  • rename Event accept_all_application_letters

  • update accepted_application_count to use both accepted states

  • rename application_letter_applicant_gongakrobatic_accepted

  • make sure, that you can filter after all statuses (pretty much refactor everything in that test) features/events_spec filter displayed application_letters

  • has as many participants as accepted applications

  • click on accept radio button --> pre_accept

  • checks states of applications

  • coaches see pre_accepted status

  • make only accepted, rejected, pending and alternative selectable, not cancled and pre_accepted

  • pre_accepted -> accepted

  • rename draft status to acceptance and rejection

  • test states

  • selectable_statuses as Application_letter variable

Actually do stuff:

  • cancel button for accepted applications
  • cancel when clicked
  • make accept button appear (alternatives)
  • only accept button when counter good (alternatives)
  • pre_accept, when clicked (alternatives)
  • make accept button appear (rejected)
  • only accept button when counter good (rejected)
  • pre_accept, when clicked (rejected)
  • make email button appear (pre_accepted)
  • ASK PO TO SEND ALL EMAILS INSTEAD OF LETTER ICON
  • ASK PO IF ONLY RECIPIENTS OF EMAIL SHOULD FINALLY BE ACCEPTED
  • redirect to mail sending acceptance email when clicked
  • accept ONLY recipients of email after mail button clicked

Acceptance criteria

  • When the event is in state execution, organizers should see a button "cancel" in the row of each accepted participant.

  • When the organizer pushed the button, then the application is canceled, meaning that the applicant will not participate in the event (similar to rejected)

  • After pushing the cancel button, the organizer can choose a new participant out of the list of alternatives (Nachrücker) and if no alternatives present, then a list of rejected applicants.

  • Applicants who have been accepted in the execution state but did not get an email yet have an emal icon next to the "angenommen" label that lead to the page for sending the acceptance email to him / her.

  • After discussion with PO: The new pre_accepted state leads (on the application_letters index page) to a status display of either "pending" (if before deadline) or "In Beabeitung" (if after deadline)

See Epic_3.3: Application States (Refs #233)

UI

Event is in execution state.

folie1

After pushing one "abgesagt" button: "Nachrücker" can be accepted.

folie2

After pushing the "annehmen" button

folie3

After pushing one other "abgesagt button": rejected applicants can be accepted

folie4

As one pdf file

@Baschdl Baschdl added the ready label Jan 5, 2017
@Baschdl Baschdl added in progress and removed ready labels Jan 11, 2017
@Baschdl Baschdl added this to the Sprint 4 milestone Jan 11, 2017
frederike-ramin pushed a commit that referenced this issue Jan 24, 2017
aloeser added a commit that referenced this issue Jan 24, 2017
frederike-ramin pushed a commit that referenced this issue Jan 26, 2017
@ekrebs5 ekrebs5 mentioned this issue Jan 28, 2017
2 tasks
aloeser added a commit that referenced this issue Jan 29, 2017
* Rename Email Template statuses #242

* use case when for computing the corresponding application status #242

* make case then more readable #242
aloeser added a commit that referenced this issue Feb 4, 2017
* event model method for phase #233

* added tests for event model phase function

* Add Test for event model function after_deadline? #233

* Revert Whitespace change #233

* Create canceled+pre_accepted state plus refactor part 1 #242

* Make only designated radio buttons selectable - Refactoring part 2 #242

* Fix tests for new states - Refactoring Part 3 #242

* Make counter test more sensable - Refactoring Part 4 #242

* Rename Email Template statuses #242

* Outsource selectable statuses to class method #242

* Convert pre_accepted into accepted by sending mail #242

* Fix feature test for pre_accepted -> accepted #242

* added some more application status changing tests #242

* move accepting all pre_accepted participants on acceptance mail from controller to model #242

* 242 go back from pre_accepted

* fix some things to get rid of pre_accepted #242

* remove unneccessary var in test #242

* remove duplicated tests #242

* move 2 expect few lines higher #242

* use factory for no status_status_notification_sent #242

* some requested changes #242

* #242 add missing locales

* #242 remove code duplication in test

* update schema.rb #242
aloeser added a commit that referenced this issue Feb 4, 2017
aloeser added a commit that referenced this issue Feb 4, 2017
aloeser added a commit that referenced this issue Feb 5, 2017
aloeser added a commit that referenced this issue Feb 5, 2017
* event model method for phase #233

* added tests for event model phase function

* Add Test for event model function after_deadline? #233

* Revert Whitespace change #233

* Create canceled+pre_accepted state plus refactor part 1 #242

* Make only designated radio buttons selectable - Refactoring part 2 #242

* Fix tests for new states - Refactoring Part 3 #242

* Make counter test more sensable - Refactoring Part 4 #242

* Add canceled button for accepted applicants #242

* Make alternatives pre acceptable #242

* Rename Email Template statuses #242

* Outsource selectable statuses to class method #242

* Pop stashed tests #242

* Convert pre_accepted into accepted by sending mail #242

* Fix feature test for pre_accepted -> accepted #242

* added some more application status changing tests #242

* move accepting all pre_accepted participants on acceptance mail from controller to model #242

* 242 go back from pre_accepted

* fix some things to get rid of pre_accepted #242

* remove unneccessary var in test #242

* remove duplicated tests #242

* move 2 expect few lines higher #242

* use factory for no status_status_notification_sent #242

* some requested changes #242

* working state (not working) #242

* add tests for cancel and accept button #242

* working state #242

* fix feature tests for cancel and alternatives #242

* fix another test related to alternatives #242

* remove duplicated model function #242

* display either envelope or cancel button #242

* change factory to use after(:build) #242

* rename factory trait for consistency #242
aloeser added a commit that referenced this issue Feb 5, 2017
querenker added a commit that referenced this issue Feb 5, 2017
aloeser added a commit that referenced this issue Feb 5, 2017
aloeser added a commit that referenced this issue Feb 5, 2017
aloeser added a commit that referenced this issue Feb 5, 2017
aloeser added a commit that referenced this issue Feb 5, 2017
aloeser added a commit that referenced this issue Feb 5, 2017
aloeser added a commit that referenced this issue Feb 5, 2017
aloeser added a commit that referenced this issue Feb 5, 2017
aloeser added a commit that referenced this issue Feb 5, 2017
* event model method for phase #233

* added tests for event model phase function

* Add Test for event model function after_deadline? #233

* Revert Whitespace change #233

* Create canceled+pre_accepted state plus refactor part 1 #242

* Make only designated radio buttons selectable - Refactoring part 2 #242

* Fix tests for new states - Refactoring Part 3 #242

* Make counter test more sensable - Refactoring Part 4 #242

* Add canceled button for accepted applicants #242

* Make alternatives pre acceptable #242

* Rename Email Template statuses #242

* Outsource selectable statuses to class method #242

* Pop stashed tests #242

* Convert pre_accepted into accepted by sending mail #242

* Fix feature test for pre_accepted -> accepted #242

* added some more application status changing tests #242

* move accepting all pre_accepted participants on acceptance mail from controller to model #242

* 242 go back from pre_accepted

* fix some things to get rid of pre_accepted #242

* remove unneccessary var in test #242

* remove duplicated tests #242

* move 2 expect few lines higher #242

* use factory for no status_status_notification_sent #242

* some requested changes #242

* working state (not working) #242

* add tests for cancel and accept button #242

* working state #242

* fix feature tests for cancel and alternatives #242

* fix another test related to alternatives #242

* remove duplicated model function #242

* display either envelope or cancel button #242

* change factory to use after(:build) #242

* add function to event model to check for alternatives #242

* view tests for accepting rejected #242

* check also for href in feature tests #242 working state

* allow status change rejected->accepted #242

* fix broken feature test #242

* some more test fixing #242

* refactoring tests, one more test #242

* fix typo #242

* fix errors introduced by merge #242

* fix typo #242

* remove save_page #242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Product Backlog
3: Participant Selection (Tobi)
Development

No branches or pull requests

4 participants