Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US_3.14: Send Emails #55

Closed
14 tasks done
tobiasduerschmid opened this issue Nov 22, 2016 · 8 comments
Closed
14 tasks done

US_3.14: Send Emails #55

tobiasduerschmid opened this issue Nov 22, 2016 · 8 comments

Comments

@tobiasduerschmid
Copy link
Contributor

tobiasduerschmid commented Nov 22, 2016

As
organizer

I want to
easily send emails out of the workshop portal

in order to
save time and keep the portal self-contained.

estimation: 40

Tasks

UI

  • create generic reusable email-form
  • create new email view according to Epic 3.2 (including the generic email-form)
  • substitute modal with the email view
  • connect UI with technical infrastructure

technical infrastructure

  • create fake E-Mail address
  • set default sender address
  • create generic mail template
  • allow multiple recipients
  • send E-Mails
  • store gmail credentials
  • tests
  • answer to field
  • documentation
  • refactor tests

Notes

  • The customers prefer to send from a generic email address of the workshop portal with a customized answer-to email address.

Acceptance criteria

  • The view for sending emails contain a "From"-field for entering the sender email address.

  • The entered sender email address is validated in terms of name"@"[subdomains"."]domain"."topLevelDomain

  • When the user hits the send button, the email is sent to the receivers and received within at most 30 minutes.

  • The user can choose between inserting the selected receivers in the "To" or "BCC" field.

  • There can be many receivers specified. The user gets visual response for the separation of receivers email addresses.

  • Receivers are automatically entered when the organizer used the send-acceptance-mails-button or the send-rejection-mails-button. Please instruct the other teams how to use this feature for other use cases.

  • Emails are not classified as junk by usual spam filters.

  • If passwords are stored persistently, they are stored encrypted

  • The solution is easy to use as specified in the QAS below.

  • Emails should support multi-line-contend

Quality Attribute Scenario for Usability

email_req

As PDF

@tobiasduerschmid
Copy link
Contributor Author

tobiasduerschmid commented Nov 22, 2016

@tobiasduerschmid
Copy link
Contributor Author

Belongs to Epic_3.2: Emails (Refs #57)

@Baschdl
Copy link
Member

Baschdl commented Nov 23, 2016

A possibility mentioned by @Raandom could be SendGrid. It's a "transactional email delivery and management service" (wikipedia), but I think it doesn't fit our needs.

@tobiasduerschmid
Copy link
Contributor Author

tobiasduerschmid commented Nov 23, 2016

@Baschdl: Why do you think, it doesn't fit our needs?
@Raandom: As I see, this service is not free on charge. Do you know free solutions?

@Baschdl
Copy link
Member

Baschdl commented Nov 23, 2016

@hpi-swt2/team-d-16 There is also a free subscription: "Send 12,000 emails per month and store 2,000 contacts for free.". But to whitelist our domain we need a dedicated ip address, which is only available with a pro subscription.
It doesn't fit our needs because every sender mail domain must be whitelisted and we would conflict with e.g. the HPI infrastructure (SPF (Sender Policy Framework)...) when we do this (I created a dummy account, if someone wants to play with it text me).

timbasel added a commit that referenced this issue Dec 15, 2016
* Featured Issue #55 added initial views

* Featured Issue #55 Added failing tests

* Featured Issue #55 added new routes,controller actions, views and locals

* Featured Issue #55 added emails controller and email model

* Featured Issue #55 Added more tests, improved UI

* Featured Issue #55 fixed failing tests

* Featured Issue #55 fixed merging commit error

* Integrated Email Backend with UI

* Add Copy Button to Email Page

* Add Tests for Email Partial

* Extended acceptance/rejection feature tests

* Failing tests for #55 avoid bcc

* Implement bcc avoiding for #55

* Failing tests for #55 avoid bcc

* Implement avoid bcc with strings for #55

* Make send_email a class method #55

* Integrated updated Email Backend

* Fixed changes that where missing after merge

* Removed DB-Table for Emails

* Renamed TO and BCC in Email UI

* Renamed TO and BCC in Email UI

* Updated test of email sending

* Updated test of email sending

* Updated Email UI, refactored naming scheme and tests

* Removed unused test file
timbasel added a commit that referenced this issue Dec 15, 2016
* Featured Issue #55 added initial views

* Featured Issue #55 Added failing tests

* Featured Issue #55 added new routes,controller actions, views and locals

* Featured Issue #55 added emails controller and email model

* Featured Issue #55 Added more tests, improved UI

* Featured Issue #55 fixed failing tests

* Featured Issue #55 fixed merging commit error

* Integrated Email Backend with UI

* Add Copy Button to Email Page

* Add Tests for Email Partial

* Extended acceptance/rejection feature tests

* Failing tests for #55 avoid bcc

* Implement bcc avoiding for #55

* Failing tests for #55 avoid bcc

* Implement avoid bcc with strings for #55

* Make send_email a class method #55

* Integrated updated Email Backend

* Fixed changes that where missing after merge

* Removed DB-Table for Emails

* Renamed TO and BCC in Email UI

* Renamed TO and BCC in Email UI

* Updated test of email sending

* Updated test of email sending

* Updated Email UI, refactored naming scheme and tests

* Removed unused test file

* Fix for not registered Button Click

* Fix broken show/hide recipients option for Email

* Fixed double Negation of hide_recipients
@tobiasduerschmid
Copy link
Contributor Author

tobiasduerschmid commented Dec 16, 2016

Feedback

When I enter a multi line content in the UI, the send email does not have the new lines.
See http://stackoverflow.com/questions/16063312/new-lines-r-n-are-not-working-in-email-body

@Baschdl Baschdl modified the milestones: Sprint 3, Sprint 2 Dec 16, 2016
Lando-L pushed a commit that referenced this issue Jan 4, 2017
Lando-L pushed a commit that referenced this issue Jan 4, 2017
timbasel added a commit that referenced this issue Jan 19, 2017
* Featured Issue #55 added initial views

* Featured Issue #55 Added failing tests

* Featured Issue #55 added new routes,controller actions, views and locals

* Featured Issue #55 added emails controller and email model

* Featured Issue #55 Added more tests, improved UI

* Featured Issue #55 fixed failing tests

* Featured Issue #55 fixed merging commit error

* Integrated Email Backend with UI

* Add Copy Button to Email Page

* Add Tests for Email Partial

* Extended acceptance/rejection feature tests

* Failing tests for #55 avoid bcc

* Implement bcc avoiding for #55

* Failing tests for #55 avoid bcc

* Implement avoid bcc with strings for #55

* Make send_email a class method #55

* Integrated updated Email Backend

* Fixed changes that where missing after merge

* Removed DB-Table for Emails

* Renamed TO and BCC in Email UI

* Renamed TO and BCC in Email UI

* Updated test of email sending

* Updated test of email sending

* Updated Email UI, refactored naming scheme and tests

* Removed unused test file

* Fix for not registered Button Click

* Fix broken show/hide recipients option for Email

* Fixed double Negation of hide_recipients

* Simplified Radio Buttons to fix email visibility bug

* Featured Issue #55: Added tests

* Featured Issue #55: Fixed added tests

* Fixed new lines in Emails and truncation of event_details

* Standardize the layout of event_details

* Refactored Email, improved routes, template saving

* Refactored Tests

* Finished refactoring of email service and tests.

* Merge branches '38_3.10_SaveEmailDrafts' and 'dev' of https://github.com/hpi-swt2/workshop-portal into 38_3.10_SaveEmailDrafts

* Fixed Changes to the Gemfile.lock

* Fixed authentication for email page, updated validation to show error messages

* Added Support for default Templates, when no other status is set

* Fixed Test Name

* Fixed broken variable

* Fixed accidently deleted copy recipients button and added a view test

* Fixed naming of css file

* Fixed multiple issues found in code review
- Renamed Templates to Vorlagen in I18n
- Added ability tests

* Fixed paranthesis

* Added invalid testcase

* Removed duplicate tests + moved invalid testcases to own test

* Fixed email copy + refactored things annoted in PR

* Fixed merged, by adding deleted route and removing old tests

* Fixed controller method in model ;)

* Fixed controller method in model ;)

* That was strange

* Added setting of hide_recipients status saved in template

* Renamed Headline
@timbasel timbasel closed this as completed Feb 2, 2017
@Baschdl
Copy link
Member

Baschdl commented Feb 2, 2017

@tobiduer Did you accept this user story?

@tobiasduerschmid tobiasduerschmid removed this from 3: Participant Selection (Tobi) in Product Backlog Feb 2, 2017
timbasel added a commit that referenced this issue Feb 3, 2017
* Featured Issue #55 added initial views

* Featured Issue #55 Added failing tests

* Featured Issue #55 added new routes,controller actions, views and locals

* Featured Issue #55 added emails controller and email model

* Featured Issue #55 Added more tests, improved UI

* Featured Issue #55 fixed failing tests

* Featured Issue #55 fixed merging commit error

* Integrated Email Backend with UI

* Add Copy Button to Email Page

* Add Tests for Email Partial

* Extended acceptance/rejection feature tests

* Failing tests for #55 avoid bcc

* Implement bcc avoiding for #55

* Failing tests for #55 avoid bcc

* Implement avoid bcc with strings for #55

* Make send_email a class method #55

* Integrated updated Email Backend

* Fixed changes that where missing after merge

* Removed DB-Table for Emails

* Renamed TO and BCC in Email UI

* Renamed TO and BCC in Email UI

* Updated test of email sending

* Updated test of email sending

* Updated Email UI, refactored naming scheme and tests

* Removed unused test file

* Fix for not registered Button Click

* Fix broken show/hide recipients option for Email

* Fixed double Negation of hide_recipients

* Simplified Radio Buttons to fix email visibility bug

* Featured Issue #55: Added tests

* Featured Issue #55: Fixed added tests

* Fixed new lines in Emails and truncation of event_details

* Standardize the layout of event_details

* Refactored Email, improved routes, template saving

* Refactored Tests

* Finished refactoring of email service and tests.

* Merge branches '38_3.10_SaveEmailDrafts' and 'dev' of https://github.com/hpi-swt2/workshop-portal into 38_3.10_SaveEmailDrafts

* Fixed Changes to the Gemfile.lock

* Fixed authentication for email page, updated validation to show error messages

* Added Support for default Templates, when no other status is set

* Fixed Test Name

* Fixed broken variable

* Fixed accidently deleted copy recipients button and added a view test

* Fixed naming of css file

* Fixed multiple issues found in code review
- Renamed Templates to Vorlagen in I18n
- Added ability tests

* Fixed paranthesis

* Added invalid testcase

* Removed duplicate tests + moved invalid testcases to own test

* Load Templates via JS

* Fixed email copy + refactored things annoted in PR

* Fixed merged, by adding deleted route and removing old tests

* Fixed controller method in model ;)

* Fixed controller method in model ;)

* That was strange

* Added setting of hide_recipients status saved in template

* Fix whitespace

* Issue #53: Refactored emails.js

* Remove duplicated tests

* Refactored to email_template traits, and featuretest

* Renamed email_template trait names to be consistend with the data

* Added test for setting hide_recipients

* Changed order of not

* Fixed syntax error with not and !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants