Skip to content

Workflow

Eva edited this page May 12, 2017 · 3 revisions

How to complete an issue

  • Branch form developer branch
  • Implement functionality fullfilling the issue description
  • Make sure of the following things:
    • Unit Tests for all acceptance criteria exist and pass successfully
    • try it at least once yourself in a browser
    • Code (Test) Coverage is 100% (in special cases ask for exception)
    • Codings Standards are adhered to
    • Documentation for design and architecture decisions exists (WIKI + all public methods are YARD annotated)
    • Refactore Code whenever possible
  • Open a Pull Request to developer branch
  • At least one (core) team member has to review and approve
  • Merge into developer branch
  • Developer branch runs succesfully on Heroku, POs can look at it, Issue is closed (zB per commit message)
  • PO accepts feature and archives the issue on waffle.io (into DONE column)

Git Commits

  • reference the issue number (eg #42)
  • Verb im Imperativ als commit message Beginn (z.B. Add, Change, Fix etc.)
  • Siehe auch http://chris.beams.io/posts/git-commit/
    1. Separate subject from body with a blank line
    2. Limit the subject line to 50 characters
    3. Capitalize the subject line
    4. Do not end the subject line with a period
    5. Use the imperative mood in the subject line
    6. Wrap the body at 72 characters
    7. Use the body to explain what and why vs. how

Waffle.io

  • Backlog ist Product Backlog, nicht Sprint Backlog (das kann man durch filtern nach Sprint einsehen)
  • Ready ist ready (also theoretisch bereit zum Anfangen, alle Abhängigkeiten bereits erledigt), nicht unbedingt aktueller Sprint