small type annotation fixes

hpicrypto · Jan 19, 2023 · 7d1fb8e · 7d1fb8e
1 parent 5dde37b
commit 7d1fb8e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/kvac/parameters.py b/kvac/parameters.py
@@ -1,4 +1,4 @@
-from typing import List, Tuple, NamedTuple
+from typing import List, NamedTuple, Optional, Tuple
 from curve25519_dalek.ristretto import RistrettoPoint
 from curve25519_dalek.scalar import Scalar
 
@@ -62,7 +62,7 @@ class ServerKeyPair(NamedTuple):
     I: RistrettoPoint
 
     @classmethod
-    def generate(cls, system: SystemParams, sho: RistrettoSho = None) -> 'ServerKeyPair':
+    def generate(cls, system: SystemParams, sho: Optional[RistrettoSho] = None) -> 'ServerKeyPair':
         if sho is None:
             sho = RistrettoSho(
                 b'Signal_HPICrypto_SecMes2223_KVAC_Credential_ServerKeyPair_Generation',

diff --git a/tests/test_system_params.py b/tests/test_system_params.py
@@ -59,7 +59,7 @@ def get_point_from_hardcoded_system(system_index: int) -> RistrettoPoint:
     )
 
 
-def test_generate_signal_hardcoded_test_system() -> kvac.SystemParams:
+def test_generate_signal_hardcoded_test_system():
     # assumption: kvac.RistrettoSho uses HMAC-SHA-256 SHO
     sho = kvac.RistrettoSho(
         b"Signal_ZKGroup_20200424_Constant_Credentials_SystemParams_Generate",