New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance is not confirmed #4

Open

fulldecent opened this issue Jan 14, 2016 · 1 comment

Contributor

fulldecent commented Jan 14, 2016

It is stated:

When performance is a concern, better to use nil as a default value.

There is no proof presented that not executing a nil closure is faster than executing an empty closure.

If such proof does not exist, a better statement might be:

If parts of the function may be skipped when closures are not provided then it is better to use nil as a default value.

The text was updated successfully, but these errors were encountered:

Contributor Author

fulldecent commented Feb 28, 2018

To be clear, are you still accepting contributions to this project?? If so would a PR that fixes this be in scope to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment