Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update is_cjk #14

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Update is_cjk #14

merged 1 commit into from
Jan 3, 2019

Conversation

BLKSerene
Copy link
Contributor

  1. Add Tangut script (西夏文), which is used to write the Tangut language in Western Xia (西夏) Empire during China's Song (宋) Dynasty.
  2. Add Nüshu (女书), which is used by women in Jiangyong (江永) County of Hunan (湖南) province of southern China.
  3. Add Kana Supplement and Kana Extended-A.

@alvations alvations self-requested a review December 31, 2018 05:33
@alvations alvations self-assigned this Dec 31, 2018
@alvations
Copy link
Contributor

Thanks for the contribution. Sorry for the delayed response.

It's a little more complicated than merging the changes, would you be able to make the changes in Perl in the original Moses decoder's tokenizer first?

Otherwise, we could also create a argument in the is_cjk function to cover extended CJK scripts as you have listed above.

@alvations alvations merged commit 691b251 into hplt-project:master Jan 3, 2019
@alvations
Copy link
Contributor

Heck the whole (L)GPL thing and consideration for providence. We're going rouge so merging this.

Thanks @BLKSerene!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants