Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: various internal cleanup #7

Merged
merged 1 commit into from
Jan 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,6 @@ jobs:
prettier:
name: Prettier
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
with:
ref: ${{ github.head_ref }}
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 18.x
- name: Install Prettier
run: npm install --global prettier
- name: Run Prettier
run: prettier --check --no-error-on-unmatched-pattern "**/*.{json,md,yml,yaml}"
prettier_action:
name: Prettier 2
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

# v2.0.5 - 2024-01-15

### Removed

- Removed all unused references to remote Wikipedia card image assets.
- Various internal cleanup.

# v2.0.4 - 2023-11-06

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.0.4
2.0.5
3 changes: 1 addition & 2 deletions config/runtime.exs
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,5 @@ if config_env() == :prod do
config :logger, level: String.to_atom(System.get_env("LOG_LEVEL", "info"))

config :tarot_cup,
datadir: System.get_env("DATADIR", ""),
local_images?: System.get_env("LOCAL_IMAGES")
datadir: System.get_env("DATADIR", "")
end
2 changes: 0 additions & 2 deletions lib/tarot_cup/card.ex
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
defmodule TarotCup.Card do
defstruct id: nil, name: nil, rule: nil, image_url: nil

@all_cards "#{:code.priv_dir(:tarot_cup)}/cards.json"
|> File.read!()
|> Jason.decode!()
Expand Down
4 changes: 0 additions & 4 deletions lib/tarot_cup/handler/game.ex
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,6 @@ defmodule TarotCup.Handler.Game do
|> Embed.put_field("Last Activity", format_dt(game.last_activity))
end

defp local_images? do
Application.get_env(:tarot_cup, :local_images?, false)
end

defp format_dt(dt) do
Timex.format!(dt, "{Mshort} {D}, {YYYY} :: {h24}:{m}:{s} UTC")
end
Expand Down
Loading