Files opened by "Copy to" on iOS are not re-openable

[amake]

On iOS, files can be opened from other apps in two ways:

• "Open in MyApp"
  • Received in application(_:open:options:) as an "open in place" security-scoped resource
  • options map contains UIApplicationOpenURLOptionsOpenInPlaceKey: true
• "Copy to MyApp"
  • Received in application(_:open:options:) as a regular (non-security-scoped) file URI
  • File is already copied to app container, so can always be persistently accessed
  • options map contains UIApplicationOpenURLOptionsOpenInPlaceKey: false in my observation (could hypothetically have nil or the key might be absent)

Previously, I thought that with correct setup (proper keys in Info.plist), all apps would be able to "Open In", but it turns out that some, in particular Google Drive, can never "Open In" but only offer "Copy To", regardless of the target application and its capabilities.

file_picker_writable currently handles receiving "Copy To" files OK: it ignores the failure to obtain a security scope in _prepareUrlForReading:

file_picker_writable/ios/Classes/SwiftFilePickerWritablePlugin.swift

Lines 188 to 198 in 72470d0

	private func _prepareUrlForReading(url: URL) throws -> [String: String] {
	let securityScope = url.startAccessingSecurityScopedResource()
	defer {
	if securityScope {
	url.stopAccessingSecurityScopedResource()
	}
	}
	let bookmark = try url.bookmarkData()
	let tempFile = try _copyToTempDirectory(url: url)
	return _fileInfoResult(tempFile: tempFile, originalURL: url, bookmark: bookmark)
	}

But when trying to reopen a bookmark obtained from such a file, it fails due to strict checking in readFile:

file_picker_writable/ios/Classes/SwiftFilePickerWritablePlugin.swift

Lines 104 to 106 in 72470d0

	if !url.startAccessingSecurityScopedResource() {
	throw FilePickerError.readError(message: "Unable to start accessing security scope resource.")
	}

[amake]

Now this PR fixes #4 as well.

[hpoul]

thanks, looks good, just two small things.. see my inline comments and let me know what you think

[hpoul]

thanks, lgtm 👍️

[amake]

Thanks for merging. But somehow I don't see it in the master branch.

[hpoul]

oops sorry.. no idea how that happened.. i think i've did one force push too many..
thanks for catching that 🤦️