Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC Adding features #194

Merged
merged 18 commits into from
May 21, 2017
Merged

PC Adding features #194

merged 18 commits into from
May 21, 2017

Conversation

bamh
Copy link
Contributor

@bamh bamh commented May 21, 2017

Adding support for Jenkins using proxy:
https://issues.jenkins-ci.org/browse/JENKINS-44314
*Fixed: https://issues.jenkins-ci.org/browse/JENKINS-39654
*Changes in PC configuration section header

Hanan Bem added 18 commits January 19, 2017 13:26
…ation-tools-plugin

# Conflicts:
#	.github/PULL_REQUEST_TEMPLATE.md
#	pom.xml
#	src/main/java/com/hp/application/automation/tools/model/PcModel.java
#	src/main/java/com/hp/application/automation/tools/pc/PcClient.java
#	src/main/java/com/hp/application/automation/tools/pc/PcRestProxy.java
#	src/main/java/com/hp/application/automation/tools/run/PcBuilder.java
#	src/main/resources/com/hp/application/automation/tools/run/PcBuilder/config.jelly
#	src/test/java/com/hp/application/automation/tools/pc/MockPcModel.java
#	src/test/java/com/hp/application/automation/tools/pc/MockPcRestProxy.java
#	src/test/java/com/hp/application/automation/tools/pc/MockPcRestProxyBadResponses.java
@YafimK YafimK added this to the 5.1.0.3 milestone May 21, 2017
@AppVeyorBot
Copy link

@YafimK
Copy link
Collaborator

YafimK commented May 21, 2017

Approved for test build

@HPEbot
Copy link
Collaborator

HPEbot commented May 21, 2017

SonarQube analysis reported 4 issues

  1. CRITICAL PcRestProxy.java#L57: Explicitly import the specific classes needed. rule
  2. MAJOR PcClient.java#L61: Either log or rethrow this exception. rule
  3. MAJOR PcRestProxy.java#L132: Assign this magic number 80 to a well-named constant, and use the constant instead. rule
  4. MAJOR PcRestProxy.java#L136: Catch a list of specific exception subtypes instead. rule

@YafimK YafimK merged commit e86d97d into hpsa:latest May 21, 2017
@hpsa hpsa modified the milestones: 5.1.0.3, Release 5.2 Jun 11, 2017
pavelchuchma pushed a commit to pavelchuchma/hp-application-automation-tools-plugin that referenced this pull request Nov 21, 2018
pavelchuchma pushed a commit to pavelchuchma/hp-application-automation-tools-plugin that referenced this pull request Apr 15, 2019
defect #616017: [Jenkins] can "run successfully" disabled job from Octane
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants