-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce DynamicBlockVector #74
Conversation
@peterrum sure! I will try this out today |
Tried it, looks good to me. Should we merge it right now or wait till those related PRs get merged to deal.ii master branch first? |
I am fine with merging. Hopefully, the PRs are not too controversial and are merged in the next days! |
@vovannikov How do you run your application. Do I need to make some adjustments to the parameters so that I test all features? |
Do you mean functionality not related to this PR? If so, basically I do this couple of runs:
It won't still test the non-greedy mode of the Grain Tracker but that feature will be removed shortly. |
If I run the second test with 40 processes, I get:
That does not look right. If I run with 2 processes, the error message does not come. |
Thank you for the report! I've got an idea why it happens, will work on it today. |
This PR introduces a new block vector type. The motivation is that I have the feeling that the normal block vector class from deal.II is not designed for adaptability changing number of blocks, requiring annoying additional pre- and post-processing steps.
This PR only adds the new vector and does not simplify the usage yet, which will be done in a follow-up PR.
@vovannikov Could you try this PR out. It depends on dealii/dealii#13606 and dealii/dealii#13605.