Fixed WHILE-MEASURING macro for case when CATCH-ERRORS-P argument is given #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…given
Previously it didn't catched error and other outer handler was able to catch it.
For example in this situation WHILE-MEASURING will not return it's measurments:
CL-USER> (ignore-errors
(lift:while-measuring (t :measure-seconds)
(sleep 5)
(error "Some shit happened")))
NIL
#<SIMPLE-ERROR 70B0125B13>
but I'd expect it to return:
NIL
(5.007D0)
#<SIMPLE-ERROR 70B0004B73>
This commit fixes the problem.
svetlyak40wt
added a commit
to svetlyak40wt/trivial-timeout
that referenced
this pull request
Nov 23, 2021
This fixes issues of having signals from the body code signaled in the incorrect thread. Also, I've fixed usage of the LIFT:WHILE-MEASURING in tests. From some moment it started to require a CATCH-ERROR-P argument. Another error was fixed in the WHILE-MEASURING. It prevented it from correct error catching. This pull-request should be merged first: hraban/lift#7
This was referenced Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it didn't catched error and other outer handler was able to catch it.
For example in this situation WHILE-MEASURING will not return it's measurments:
but I'd expect it to return:
This commit fixes the problem.