added preprocessor directive for proper import of opus brew package #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hraban
added a commit
that referenced
this pull request
Feb 28, 2017
pkg-config --cflags always puts you in the opus/ directory where opus.h directly lives. No need to prefix with opus/. That just happened to work because it was symlinked into /usr/include/opus, but we don't need to rely on that now that we're using pkg-config. Based on Tobias Wellnitz's comment (#12)
|
Hi, thanks for the bug report. You're completely right. In fact, even on Linux, we don't need opus/: it just happens to work because opus/ happens to live in /usr/include. But pkg-config puts us in the bare opus/ directory, and since we're using pkg-config --cflags for this, we can completely trust that, instead. I've fixed it in another PR (#13), so I'm closing this one. Thanks again 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
there seems to be a difference in the installation path where the brew packet manager installs on MacOS the opus library.
While on Linux the import statement:
#include <opus/opus.h>works fine, in MacOS it doesn't. On MacOS the opus.pc which comes with brew is slightly different and requires the following import:
#include <opus.h>I added preprocessor directive to check the platform and import the correct opus.h from the correct path.