-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] [FEAT] Add TypeScript | Bump actions/checkout
to v3
& Node.js
to v16
| Prettier Formatting
#7
Conversation
actions/checkout
to v3
, Bump Node.js
to v16
actions/checkout
to v3
& Node.js
to v16
| Prettier Foramtting
actions/checkout
to v3
& Node.js
to v16
| Prettier Foramttingactions/checkout
to v3
& Node.js
to v16
| Prettier Formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, I'd be okay with merging it in once you're ready.
Welcome! Sure, ready to merge. Edit: Also, one small request from me; please merge all the commits and NOT squash commit merge. Here's the test (/release) plan:
What do you think @hramos? P.S.: I would like to follow the release process with you to learn and understand more about the same. Lmk :) |
ping @hramos :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - go ahead with plan
Sure. |
Merging this PR, and will proceed according to the test & release plan. |
Summary
Node.js
tov16
actions/checkout
tov3
yarn format-check
andyarn prettier
need-attention.js
toindex.ts
yarn build
->tsc
-> builds and outputs tolib/index.js
(es6
)Changelog
Changelog (click to expand)
actions/checkout@v3
2389403 by @Pranav-yadav@octokit/webhooks-definitions
TS 688dd7a by @Pranav-yadav@octokit/webhooks-definitions
TS 4a2d2dc by @Pranav-yadav@types/node
2aa78e2 by @Pranav-yadavactions/checkout
tov3
29d548f by @Pranav-yadavNode.js
tov16.0.0
4d38bf2 by @Pranav-yadav