Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] [FEAT] Add TypeScript | Bump actions/checkout to v3 & Node.js to v16 | Prettier Formatting #7

Merged
merged 17 commits into from
Jun 15, 2023

Conversation

Pranav-yadav
Copy link
Collaborator

@Pranav-yadav Pranav-yadav commented May 26, 2023

Summary

  • Bump Node.js to v16
  • Bump actions/checkout to v3
  • Add and set up TypeScript
  • Refactor to use Types
  • Add Prettier formatting yarn format-check and yarn prettier
  • Rename need-attention.js to index.ts
  • Set Up: yarn build -> tsc -> builds and outputs to lib/index.js (es6)

NOTE: This will need a major release. i.e. v2.0.0

Changelog

Changelog (click to expand)

@Pranav-yadav Pranav-yadav changed the title [BREAKING] [FEAT] Add TypeScript, Bump actions/checkout to v3, Bump Node.js to v16 [BREAKING] [FEAT] Add TypeScript | Bump actions/checkout to v3 & Node.js to v16 | Prettier Foramtting May 26, 2023
@Pranav-yadav Pranav-yadav changed the title [BREAKING] [FEAT] Add TypeScript | Bump actions/checkout to v3 & Node.js to v16 | Prettier Foramtting [BREAKING] [FEAT] Add TypeScript | Bump actions/checkout to v3 & Node.js to v16 | Prettier Formatting May 26, 2023
Copy link
Owner

@hramos hramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, I'd be okay with merging it in once you're ready.

@Pranav-yadav Pranav-yadav marked this pull request as ready for review May 31, 2023 07:55
@Pranav-yadav
Copy link
Collaborator Author

Pranav-yadav commented May 31, 2023

Thanks for working on this, I'd be okay with merging it in once you're ready.

Welcome! Sure, ready to merge.
Actually, I was waiting because I wanted to make sure before release it is tested properly and that there won't be any regression(s).

Edit: Also, one small request from me; please merge all the commits and NOT squash commit merge.
Such that If I need to revert or modify anything I can make use of the commits directly :)

Here's the test (/release) plan:

  1. We make sure the build is correct,
  2. Publish a Prerelease e.g.: v2.0.0-RC.1, so we can test before the actual release in actual live env.,
  3. Test using the Prerelease (v2.0.0-RC.1) (using main.yml)
  4. If everything is fine, publish the latest i.e. v2.0.0

What do you think @hramos?

P.S.: I would like to follow the release process with you to learn and understand more about the same. Lmk :)

@Pranav-yadav
Copy link
Collaborator Author

ping @hramos :)

Copy link
Owner

@hramos hramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - go ahead with plan

@Pranav-yadav
Copy link
Collaborator Author

Sure.
Also thanks for inviting me as a collaborator! 鉂わ笍

@Pranav-yadav
Copy link
Collaborator Author

Merging this PR, and will proceed according to the test & release plan.

@Pranav-yadav Pranav-yadav merged commit 1c5931b into hramos:master Jun 15, 2023
@Pranav-yadav Pranav-yadav added this to the v2.0.0 milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants