Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Might want to add httr package dependency to README #1

Closed
stefanavey opened this issue Jan 12, 2015 · 3 comments
Closed

Might want to add httr package dependency to README #1

stefanavey opened this issue Jan 12, 2015 · 3 comments

Comments

@stefanavey
Copy link

Tried code in README but failed because write_disk function was not found. Installed and loaded httr package and then I was able to use the get_flu_data function.

Installing and loading cdcflueview didn't give any errors even though I didn't have the httr package installed (I'm not sure how this works). In any case, may want to mention this is required in README.

@hrbrmstr
Copy link
Owner

Thx. R should have said something about an httr dependency in a console
message (as that dependency is in the package DEPENDS file) but I'll take a
look.

On Mon, Jan 12, 2015 at 12:01 PM, stefanavey notifications@github.com
wrote:

Tried code in README but failed because write_disk function was not
found. Installed and loaded httr package and then I was able to use the
get_flu_data function.

Installing and loading cdcflueview didn't give any errors even though I
didn't have the httr package installed (I'm not sure how this works). In
any case, may want to mention this is required in README.


Reply to this email directly or view it on GitHub
#1.

@stefanavey
Copy link
Author

You're right. It does give an error if I remove 'httr' and then try to
install cdcfluview. Not sure why that didn't happen the first time... My
best guess is my version of httr was old

thanks

On Mon, Jan 12, 2015 at 12:05 PM, boB Rudis notifications@github.com
wrote:

Thx. R should have said something about an httr dependency in a console
message (as that dependency is in the package DEPENDS file) but I'll take
a
look.

On Mon, Jan 12, 2015 at 12:01 PM, stefanavey notifications@github.com
wrote:

Tried code in README but failed because write_disk function was not
found. Installed and loaded httr package and then I was able to use the
get_flu_data function.

Installing and loading cdcflueview didn't give any errors even though I
didn't have the httr package installed (I'm not sure how this works). In
any case, may want to mention this is required in README.


Reply to this email directly or view it on GitHub
#1.


Reply to this email directly or view it on GitHub
#1 (comment).

@hrbrmstr
Copy link
Owner

Actually, it's my bad. I had an older version (0.3.0) of httr required in the DESCRIPTION file. I'm pushing 0.2.1 up now to fix. Thx for noting the bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants