Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad uses of reallocIfNeeded #1

Open
benjdv opened this issue Jan 28, 2020 · 0 comments
Open

Bad uses of reallocIfNeeded #1

benjdv opened this issue Jan 28, 2020 · 0 comments

Comments

@benjdv
Copy link

benjdv commented Jan 28, 2020

Find in the source
buffer.reallocIfNeeded(...);
Instead of
buffer = buffer.reallocIfNeeded(...);

The size of the buffer is unchanged and some problems may appears (some of these problems are currently catched by the "try/catch" in the code but produce bad results.
benjdv added a commit to benjdv/drill-domain-tools that referenced this issue Jan 28, 2020
@benjdv
Update SuffixExtract.java
e279364 
Proposition of correction for the Ticket "Bad uses of reallocIfNeeded hrbrmstr#1"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benjdv