Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced single-shot HTTP requests with retry logic #42

Merged
merged 2 commits into from
May 6, 2020
Merged

replaced single-shot HTTP requests with retry logic #42

merged 2 commits into from
May 6, 2020

Conversation

jameslamb
Copy link
Contributor

Thanks for this project!

In this PR, I'd like to propose swapping out calls to httr::POST(), httr::HEAD() etc. with httr::RETRY(). This will make the package more resilient to transient problems like brief network outages or periods where Drill is briefly unavailable. In my experience, using retry logic almost always improves the user experience with HTTP clients.

I'm working on chircollab/chircollab20#1 as part of Chicago R Collab, an R 'unconference' in Chicago.

@hrbrmstr
Copy link
Owner

This is brilliant! #ty!!!

Can you also update DESCRIPTION to add yourself? I need to tweak a few other things the REST API supports now and shld be sending this to CRAN in May. Wld def like to have you in for that push.

@jameslamb
Copy link
Contributor Author

@hrbrmstr sure, I'll do that right now! I'll take a look at the other issues too, maybe there are other things I can help with.

@hrbrmstr hrbrmstr merged commit d325ac8 into hrbrmstr:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants