-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: merge login menus #304
Comments
I believe they are kept separate for a reason, the login at the base URL is for managing jfa-go itself whereas That said I think it'd be a good idea to give jfa-go admins the option (not sure if it exists already) to serve /my/account on the base URL and put the jfa-go dash in a subpath (essentially reversing the current behaviour) so that users have a simpler URL to log into. |
I'll add an option to manually set the My Account and Admin page subfolders at some point. For now you can probably do this yourself with a reverse proxy. |
They aren't merged because each portion of this app (admin, user page, registration form) is a single page, no page reloads occur on the admin page, and having a combined log in page for both the admin and user page would mean one of them or both would have to redirect on a successful login. The "Not an Admin?" thing and the ability to hide the background on that screen were simple additions, combining the two login pages would be a bigger one and would probably worsen the experience for those who don't use the "My Account" feature. |
I don't see why you'd need a page reload idk what language is being used here but it's not hard to change endpoints on a failed request no? unless the my account section is checking the db? maybe having the main page not just be an overlay over the admin panel and actually be its own page so we dont need multiple login pages for the same thing then redirect to the correct page after login, kinda like how embystat is |
that's my point, it'd require a redirect. I'd potentially do this if I gave the login page a bit more content, so maybe I'd add it alongside extra stuff like custom messages, logos, etc. If i did it wouldn't be for a little while, maybe in 5.2. |
yeah thats fine, i think it would be nice to have but the way things are in unstable are perfectly good for now |
currently i have to guide users to the main url + /my/account, would be nice if the main login thing was all in one?
The text was updated successfully, but these errors were encountered: