Add support for -h arg

[gerdreiss]

Offering -h option by adding an option with name "help" and short name "h" and letting Scallop handle the printing of the help text

[hrj]

Thanks @gerdreiss ! The code seems to work fine but the tests are failing.

I had a quick look but couldn't figure out what's going on.

[hrj]

One thing to note, specifying the -h command to scallop is not required. Scallop is adding it automatically, by default.

So the only question is why the test is failing.

[gerdreiss]

Hi @hrj, in my understanding Scallop is adding "--help", not "-h". When -h is given as a program argument to CLIApp without having my change in place, following text is printed to the console:

-c, --config
--filter name=value [ name=value]... Transaction filters
-i, --input ...
-q, --quiet
-r, --report ...
-X, --unversioned
--help Show help message
--version
CLI Argument error: Unknown option 'h'

With my change you see:

-c, --config
--filter name=value [ name=value]... Transaction filters
-i, --input ...
-q, --quiet
-r, --report ...
-X, --unversioned
-h, --help
--version

I'll check the tests...

[hrj]

@gerdreiss Ah yes, you are right about -h.

About the test failure, FYI, I reported it upstream: scallop/scallop#129

[hrj]

@gerdreiss Rogach replied on the scallop issue, with multiple ideas. I like the idea of fixing the onError() function so that it handles the Help and Version exceptions. The behaviour would be very much like the super behavior, except we won't call sys.exit(). Instead we would rethrow the exception, as we do for ScallopException.

Do you want to take a stab at it?

[gerdreiss]

@hrj Sounds good, I'll give it a try

[coveralls]

Coverage increased (+0.5%) to 70.249% when pulling 23b18d9 on gerdreiss:help-option into a232d93 on hrj:master.