Transaction with a single posting should be an input error #130 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrj
requested changes
Jan 30, 2017
| @@ -225,6 +225,8 @@ object Processor { | |||
|
|
|||
| if (postsNoAmount.length > 1) { | |||
| throw new InputPosError(s"More than one account posted with unspecified amount: ${postsNoAmount.map(_.accName).mkString(",")}", tx.pos) | |||
| } else if (postsWithAmount.isEmpty) { | |||
| throw new InputPosError(s"Transaction with single posting: ${tx.posts.head.accName}", tx.pos) | |||
There was a problem hiding this comment.
I like the check you added (postsWithAmount.isEmpty). It is more general than I had imagined.
However, the error message seems to be too narrow. How about: "Transaction with unspecified amount"?
| ignoreDirSuiteTestCases(errorRoot, Glob("bugsInputError/**.exec")) { args: Array[String] => | ||
| assertThrows[SettingsError] { | ||
| runDirSuiteTestCases(errorRoot, Glob("bugsInputError/**.exec")) { args: Array[String] => | ||
| assertThrows[InputPosError] { |
There was a problem hiding this comment.
As part of the fix, this testcase should move to a different directory: inputError. I think the bugsInputError directory is for bugs in the error reporting code (which we are fixing now).
Apart from moving to the inputError directory, no other changes should be required.
added 2 commits
January 30, 2017 20:06
hrj
approved these changes
Jan 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hrj , I hope these changes are as you had them in mind. Cheers, gerdreiss
Edit by hrj:
closes #130