Protect input files from being over-written #116 #133
Conversation
|
|
||
| val inputFiles = filenamesToPaths(inputs.toSeq) | ||
| val repOutFiles = filenamesToPaths(settings.reports.flatMap(rep => filenamesToConfRelPaths(rep.outFiles))) | ||
| val expOutFiles = filenamesToPaths(settings.exports.flatMap(exp => filenamesToConfRelPaths(exp.outFiles))) |
There was a problem hiding this comment.
It would be nice to move the logic of getting output paths into the Settings class. That way, if we have more types of output files tomorrow, we can remember to include them when the settings class is modified. Also, peculiarities, such as "-" files, can be confined to the Settings class.
There was a problem hiding this comment.
You're right, it makes sense to have that part in the Settings class.
It seems to me that this part (App.scala, line 10) could be moved to the Settings class, too:
val writesToScreen = outFiles.contains("-") || outFiles.isEmpty
What do you think?
| exports += { | ||
| type = balance | ||
| format = xml | ||
| outFiles = [o01-include.ledger] |
There was a problem hiding this comment.
I think these tests should be split. Otherwise, the error from "overwriting o01.ledger" will mask the absence of other errors.
Hi @hrj , that's the fix for the issue #116. I'm checking for potential overwriting of input files right after the program has parsed all of them, e.g. also those that are included in other input files via the "include" instruction. Please let me know if that's what you had in mind.
Edit:
Closes #116