Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #61 Minor formatting glitch, Take 2 #141

Merged
merged 2 commits into from
Feb 25, 2017
Merged

Fix for #61 Minor formatting glitch, Take 2 #141

merged 2 commits into from
Feb 25, 2017

Conversation

gerdreiss
Copy link
Contributor

@gerdreiss gerdreiss commented Feb 25, 2017

@hrj , that should hopefully fix it.

closes #61

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 69.351% when pulling 6376d84 on gerdreiss:i67-formatting-glitch-2 into db3898b on hrj:master.

@gerdreiss gerdreiss changed the title Fix #67 Minor formatting glitch, Take 2 Fix for #61 Minor formatting glitch, Take 2 Feb 25, 2017
@hrj
Copy link
Owner

hrj commented Feb 25, 2017

Awesome, I am reviewing this. In the meanwhile, could you also add a test case for this, so that we don't regress in the future. You could just use a.ledger and a.conf.

We should probably also include the examples/complete into the test as well. Just for safety. But that's a separate topic.

@hrj
Copy link
Owner

hrj commented Feb 25, 2017

It all works. Will wait for a test case.

@gerdreiss Just a request, since you are making so many contributions: Your commit comments are all the same for a given PR. You could make it more descriptive and specific to the change. Such as "added test case for formatting", etc.

@gerdreiss
Copy link
Contributor Author

gerdreiss commented Feb 25, 2017

@hjr you're right, I'll make them more descriptive. Also, if you have any other requests or preferences regarding the "contribution process", just let me know. That's my first open source project, so I might have something to learn apart of the actual development ;)

@hrj
Copy link
Owner

hrj commented Feb 25, 2017

@gerdreiss No other comments; you are doing swell for a first open-source project 👍

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 69.351% when pulling 37b9c20 on gerdreiss:i67-formatting-glitch-2 into db3898b on hrj:master.

@hrj hrj merged commit 9e59426 into hrj:master Feb 25, 2017
@gerdreiss gerdreiss deleted the i67-formatting-glitch-2 branch February 25, 2017 18:40
@hrj hrj modified the milestones: Next release, 0.5.0 May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor formatting glitch
3 participants