Testrunner-with-args #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds extra command line arg support for test runner. Also, remove old stale output-files, so that they won't mask potential test failures.
This fixes indetation (tab -> spaces), and reformat one line. No functional changes.
You can append For example this |
Do not delete files automatically. Use in-memomry filesystem in future for output. It's safer that way (Review: PR hrj#80 / 2016-02-05).
|
Yes, the in-memory filesystem is better way to do it. I removed the line and added a todo. In-memory filesystem change can be done later, but it would be nice to have that args support first for transactions filter testing. Thanks for that |
Agreed! Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds command line support to test runner, and makes sure that old, stale files won't be used as output. This is testing-only change.
Please use commit (d9aaeb2) for review, because that is the actual commit with changes. Last commit is indentation fix (tab -> spaces), with no functional changes, but github can't show that (e.g. "diff -w")?