Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tabs seem to remain active when there are hundreds of tabs open in a session #1

Closed
hrj opened this issue Jun 16, 2017 · 7 comments

Comments

@hrj
Copy link
Owner

hrj commented Jun 16, 2017

Using chromium v58

@ghost
Copy link

ghost commented Dec 17, 2017

Just a guess, but is it because chromium (restores tabs) and (loads extensions) in parallel, as opposed to: waiting for extensions to load/init and then trying to load the tabs...

Btw, I'm curious to know more about that, in the hopes to force chromium(by modifying its source code) to wait for extensions to init before attempting any requests or load any tabs.

So, if any ideas, please let me know:)

EDIT: found all I wanted in my comment below

@ghost
Copy link

ghost commented Dec 17, 2017

Holy smokes! This extensions is god! Thank you for it!
Cheers!

EDIT: interesting chrome://discards/

@ghost
Copy link

ghost commented Dec 25, 2017

gorhill mentioned:

The browser does not wait for extensions to be fully loaded and ready before opening tabs, it's a by-design browser issue. Reported before.

here: gorhill/uBlock#2067 (comment)

EDIT: https://bugs.chromium.org/p/chromium/issues/detail?id=523634
EDIT2: I can reproduce that every time(not only the first time) if I prepend rm -rf -- /tmp/whatever before chromium --load-extension=path/to/extension --user-data-dir=/tmp/whatever with chromium 63.0.3213.0 (Developer Build) (64-bit) Revision | 12b4b3cb11d56a8ad6ce53b844e62025d4296dad-refs/heads/master@{#500808}

@hrj
Copy link
Owner Author

hrj commented Dec 25, 2017

@xftroxgpx Ah, that would explain it. Thanks for the hints.

Then I guess there is nothing to be done by us.. other than adding a note that "this extension can't prevent all tabs from loading, because of chromium's design."

@akilangh
Copy link

I noticed something strange today. Sloth wasn't working in the new Ubuntu install I did until I disabled background running of Chrome. You seeing this?

@hrj
Copy link
Owner Author

hrj commented Jan 21, 2018

I have never enabled background running of Chrome so I don't know.

If more people confirm this I can add it as a note in the description. And perhaps we can discuss mitigations. But it should be in a separate issue, me thinks.

@akilangh
Copy link

I too never used it, until today when I forgot to change the default. I would've started a new issue but didn't know if this was the issue or anything else I did. If you can confirm this setting causes it you can start a new issue. We will discuss and I will also see what can be done to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants