Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving songs up/down in queue does not work #1283

Closed
x51mon opened this issue Sep 17, 2023 · 8 comments
Closed

Moving songs up/down in queue does not work #1283

x51mon opened this issue Sep 17, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@x51mon
Copy link

x51mon commented Sep 17, 2023

Describe the bug
I can not change the order of songs in the queue with the shortcuts Shift+Up and Shift+Down, which are listed in the help menu.

To Reproduce
Steps to reproduce the behavior:

  1. Add multiple songs to queue
  2. Select song at the bottom
  3. Press Shift+Up
  4. Nothing happens

Expected behavior
Selected song moves up one position in the queue.

System (please complete the following information):

  • OS: Linux
  • Terminal: Konsole (KDE)
  • Version: 0.13.2-3
  • Installed from: AUR

Additional context
Not quite sure if it is a bug or I broke something on my side. I've installed ncspot quite some time ago, but I changed very few options and never tried to change keyboard shortcuts. Moving songs hasn't worked for a while, I'm not sure if the function worked in the past.

@x51mon x51mon added the bug Something isn't working label Sep 17, 2023
@hrkfdn
Copy link
Owner

hrkfdn commented Sep 23, 2023

Hrrrm, what I found so far: seems to be Termion backend related. With (pa)ncurses the bindings work fine.

@moabeat-berlin
Copy link

moabeat-berlin commented Sep 24, 2023

I have built version 0.13.4 on Arch from source with --features ncurses_backend and --features pancurses_backendand it didn't fix it for me. I've now remapped them to Shift+j and Shift+k in ~/.config/ncspot/config.toml. That makes them work again for now and it's similarly convenient, as you can also use j and k without Shift for moving around.

[keybindings]
"Shift+j" = "shift down"
"Shift+k" = "shift up"

btw: The shift command is not documented in the list of vim-like commands. ;-)

@hrkfdn
Copy link
Owner

hrkfdn commented Sep 25, 2023

@moabeat-berlin Did you also pass --no-default-features?

@moabeat-berlin
Copy link

moabeat-berlin commented Sep 25, 2023

No, of course I oversaw that. With this additional option (and also passing the rest of the default features), it works perfectly now! I added this as an alternative AUR package. Thanks for the help!

hrkfdn added a commit that referenced this issue Sep 29, 2023
- Is capable of 256 colors
- Can handle Shift+Up/Shift+Down/etc. (#1283)
hrkfdn added a commit that referenced this issue Sep 29, 2023
- Is capable of 256 colors
- Can handle Shift+Up/Shift+Down/etc. (#1283)
hrkfdn added a commit that referenced this issue Sep 29, 2023
- Is capable of 256 colors
- Can handle Shift+Up/Shift+Down/etc. (#1283)
@hrkfdn
Copy link
Owner

hrkfdn commented Sep 29, 2023

@moabeat-berlin I have set it to build ncspot with crossterm by default. Can you check if that works as well?

@moabeat-berlin
Copy link

@hrkfdn Works fine now! I used the build parameters from the original Arch package on the masterbranch and nothing else.

@hrkfdn
Copy link
Owner

hrkfdn commented Sep 29, 2023

@moabeat-berlin Good to know, thanks! :)

@hrkfdn
Copy link
Owner

hrkfdn commented Sep 30, 2023

Solved via #1290

@hrkfdn hrkfdn closed this as completed Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants