Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playback is stopped on deleting the last track in queue #159

Closed
KarlZeilhofer opened this issue Mar 21, 2020 · 2 comments
Closed

Playback is stopped on deleting the last track in queue #159

KarlZeilhofer opened this issue Mar 21, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@KarlZeilhofer
Copy link

Steps

  • add some tracks to the queue
  • start playback at first track
  • go down with cursor keys to last track in queue
  • hit d for delete
  • playback stopes

Related

Similar happens, when a track is added more than once to the queue, and the second instance is deleted, when the first instance is currently played (and is not the last track in the queue).

Version

0.1.2 on Linux Mint 19.2, self compiled.
@hrkfdn hrkfdn added the bug Something isn't working label Mar 22, 2020
@hrkfdn hrkfdn closed this as completed in c6b85f7 Mar 22, 2020
@hrkfdn
Copy link
Owner

hrkfdn commented Mar 22, 2020 •
edited

Thanks for the detailled report, should be fixed now

@KarlZeilhofer
Copy link
Author

great, thanks!

mtshrmn pushed a commit to mtshrmn/ncspot that referenced this issue Sep 8, 2020
@hrkfdn
only stop playback if the last item was deleted AND playing
3a941d4 
fixes hrkfdn#159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hrkfdn @KarlZeilhofer