Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation on certain actions #227

Closed
ghost opened this issue Jul 24, 2020 · 2 comments
Closed

Confirmation on certain actions #227

ghost opened this issue Jul 24, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented Jul 24, 2020

Please add a confirmation for certain actions, for example when pressing d, it should confirm "Do you want to delete this track from your playlist? Y/n". Maybe also for c, when clearing the whole queue "Are you sure you want to clear the queue?". And when quitting by pressing q "Do you want to quit ncspot?". I've been pressing these keys accidentally many times now and deleted tracks I don't know how to restore and so on...

Thanks!

hrkfdn added a commit that referenced this issue Jan 3, 2021
@hrkfdn hrkfdn closed this as completed in 9639115 Jan 3, 2021
@hrkfdn
Copy link
Owner

hrkfdn commented Jan 3, 2021

Hi! I have added a confirmation dialog before deleting the queue. I'm sorry if you lost tracks by accidentally hitting d, but I've checked and it matches the official clients behavior. Especially when a user wants to delete multiple tracks, having to confirm each deletion seems a little excessive.

@Qluxzz
Copy link
Contributor

Qluxzz commented Jan 3, 2021

Wouldn't a single prompt on single and multiple tracks be better? In the client "Remove from Playlist" is an option in the context menu so it takes two clicks to remove a track from a playlist, making it a more concious act.

I agree with the original poster that it is very dangerous to have such a destructive act hiding behind a single key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants