Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display album name for playable objects #268

Merged
merged 3 commits into from Sep 28, 2020
Merged

Conversation

mtshrmn
Copy link
Contributor

@mtshrmn mtshrmn commented Sep 18, 2020

Adds information about the album in a separate column, here's a picture for example:

image

This also appears in the queue.
Comes to implement #267

@hrkfdn
Copy link
Owner

hrkfdn commented Sep 22, 2020

Nice, thanks. I wonder if something can be done about the spacing. I have tried different things locally, e.g. using only one third as an offset for the center X position, but it always looks a little off 🤔

@mtshrmn
Copy link
Contributor Author

mtshrmn commented Sep 23, 2020

I tried adding a separation line, maybe that would help. Here are some examples with different offsets

2/3 offset:
image
7/11 offset (a bit more than the average of 1/2 and 2/3):
image
7/12 offset (average between 1/2 and 2/3):
image
1/2 offset:
image

@hrkfdn hrkfdn merged commit 77e5de5 into hrkfdn:master Sep 28, 2020
@hrkfdn
Copy link
Owner

hrkfdn commented Sep 28, 2020

I actually think 1/2 offset looks just fine, didn't thank of that, so thanks. I took the freedom to update the PR and merge it. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants