Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pile and foundation #255

Merged
merged 13 commits into from
Jun 5, 2023
Merged

Feature/pile and foundation #255

merged 13 commits into from
Jun 5, 2023

Conversation

hrntsm
Copy link
Owner

@hrntsm hrntsm commented May 28, 2023

変更点

  • 杭と独立フーチング基礎に対応
  • 梁のハンチ長がジョイント長になっていたバグの修正
  • 柱のBrep化で半径を入れるべきところを直径を入れていたバグの修正

対応するIssue番号

close #

curveList.Add(SectionCurve.CreateSolidColumnCircle(sectionPoints[3], both.D_extended_foot, localAxis[0]));
}

private static void PileExtendedTop(IReadOnlyList<Point3d> sectionPoints, Vector3d axis, List<SectionCurve> curveList, Vector3d[] localAxis, double dExtend, double d, double angle)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method PileExtendedTop has 7 arguments (exceeds 4 allowed). Consider refactoring.

return curveList;
}

private static SectionCurve[] SecRcPileToCurves(object figure, IReadOnlyList<Point3d> sectionPoints, Vector3d axis)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method SecRcPileToCurves has 51 lines of code (exceeds 25 allowed). Consider refactoring.

curveList.Add(SectionCurve.CreateSolidColumnCircle(sectionPoints[3], d, localAxis[0]));
}

private static void PileExtendedFoot(IReadOnlyList<Point3d> sectionPoints, Vector3d axis, List<SectionCurve> curveList, Vector3d[] localAxis, double d, double dExtend, double length, double angle)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method PileExtendedFoot has 8 arguments (exceeds 4 allowed). Consider refactoring.


lines.Append(GH_LineFromStbNode(nodeStart, nodeEnd), new GH_Path(0, i));
}

return lines;
}

internal GH_Structure<GH_Line> Piles()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method Piles has 45 lines of code (exceeds 25 allowed). Consider refactoring.

return curveList.ToArray();
}

private static void PileExtendedTopFoot(IReadOnlyList<Point3d> sectionPoints, Vector3d axis, List<SectionCurve> curveList, Vector3d[] localAxis, StbSecPile_RC_ExtendedTopFoot both)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method PileExtendedTopFoot has 5 arguments (exceeds 4 allowed). Consider refactoring.

return lines;
}

private void GetPcPileLines(GH_Structure<GH_Line> lines, StbPile member, int i)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method GetPcPileLines has 33 lines of code (exceeds 25 allowed). Consider refactoring.

}
}

private IEnumerable<PCPileFigure> GetFigureList(StbPile member)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method GetFigureList has 47 lines of code (exceeds 25 allowed). Consider refactoring.

return figures;
}

private void GetRcPileLines(GH_Structure<GH_Line> lines, StbPile member, int i)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method GetRcPileLines has 36 lines of code (exceeds 25 allowed). Consider refactoring.

@@ -424,5 +432,82 @@ private static Point3d[] GetOpenCurvePts(IReadOnlyList<Point3d> wallPts, StbOpen

return openCurvePts;
}

public GH_Structure<GH_Brep> Pile(IEnumerable<StbPile> piles)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method Pile has 34 lines of code (exceeds 25 allowed). Consider refactoring.

return brepList;
}

public GH_Structure<GH_Brep> Footing(IEnumerable<StbFooting> footings)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method Footing has 32 lines of code (exceeds 25 allowed). Consider refactoring.

new Point3d(pile.offset_X, pile.offset_Y, pile.level_top),
new Point3d(pile.offset_X, pile.offset_Y, pile.level_top),
};
Point3d[] sectionPoints =
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical blocks of code found in 2 locations. Consider refactoring.

new Point3d(footing.offset_X, footing.offset_Y, 0),
new Point3d(footing.offset_X, footing.offset_Y, 0),
};
Point3d[] sectionPoints =
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical blocks of code found in 2 locations. Consider refactoring.

@@ -424,5 +432,105 @@ private static Point3d[] GetOpenCurvePts(IReadOnlyList<Point3d> wallPts, StbOpen

return openCurvePts;
}

public GH_Structure<GH_Brep> Pile(IEnumerable<StbPile> piles)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method Pile has 57 lines of code (exceeds 25 allowed). Consider refactoring.

return GetFigureList(secPileProduct);
}

public static List<PCPileFigure> GetFigureList(StbSecPileProduct secPileProduct)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method GetFigureList has 45 lines of code (exceeds 25 allowed). Consider refactoring.

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File CreateLineFromStb.cs has 313 lines of code (exceeds 250 allowed). Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Jun 3, 2023

Code Climate has analyzed commit c28bcdf and detected 16 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 16

View more on Code Climate.

@hrntsm hrntsm merged commit 8f1a965 into develop Jun 5, 2023
3 of 4 checks passed
@hrntsm hrntsm deleted the Feature/pile-and-foundation branch June 5, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant