fix(context): in_treesitter_capture
#1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`in_treesitter_capture` used to compare a node:type() with what should be a capture, returning always a falsy value. The example https://github.com/hrsh7th/nvim-cmp/wiki/Advanced-techniques#disabling-completion-in-certain-contexts-such-as-comments did not work as expected, being in_treesitter_capture("comment") always not true. Now it works as expected.
1 task
`in_treesitter_capture` and `in_syntax_group` can take a list of string as argument.
Use vim.treesitter.get_captures_at_cursor()
get_captures_at_cursor() sometimes fails. Do it explicitly with get_captures_at_pos(buf, row, col)
Get row and col using vim.api and not vim.fn in in_syntax_group, as done in in_treesitter_capture
|
LGTM |
|
@f3fora This is a breaking change for Neovim users that haven't upgraded to 0.8 stable yet. The reason is that |
2 tasks
williamboman
added a commit
to williamboman/nvim-cmp
that referenced
this pull request
Oct 27, 2022
…indow * upstream/main: Use `default_capabilities()` in doc and util (hrsh7th#1254) Fix undefined new() error in example source (hrsh7th#1237) Update README to use the new default_capabilities (hrsh7th#1243) Fix hrsh7th#1217 ci Remove ansiblels test fix compatibility with nvim < 0.8 (hrsh7th#1227) Fix hrsh7th#1213 fix(context): compatibility with nvim<0.8 (hrsh7th#1224) fix(context): `in_treesitter_capture` (hrsh7th#1211) fix(entry/get_replace_range): workaround for end char matching cursor position (hrsh7th#1177)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in_treesitter_captureused to compare a node:type() with what should be a capture, returning always a falsy value.The example https://github.com/hrsh7th/nvim-cmp/wiki/Advanced-techniques#disabling-completion-in-certain-contexts-such-as-comments did not work as expected, being in_treesitter_capture("comment") always not true.
Now it works as expected.