handle cullface, help to #10597

[weihuoya]

Earth Defence Force 2 use GE_CMD_CULLFACEENABLE frequently with same value.

maybe this fall back is not necessary, I'm not familiar with other prim, if game use those, it is simple to handle it.

if (newPrim != GE_PRIM_TRIANGLES && newPrim != GE_PRIM_TRIANGLE_STRIP && newPrim != GE_PRIM_TRIANGLE_FAN && 
	cullMode != -1 && cullMode != gstate.getCullMode() ) {
	DEBUG_LOG(G3D, "flush cull mode before prim: %d", newPrim);
	drawEngineCommon_->DispatchFlush();
	gstate.cmdmem[GE_CMD_CULL] ^= 1;
	gstate_c.Dirty(DIRTY_RASTER_STATE);
}

[weihuoya]

I find GE_PRIM_RECTANGLES can process indices in software transform, but it rarely used in games with different cullmode.

[hrydgard]

This appears to somehow break the transitions between points in Virtua Tennis..

[weihuoya]

what kind of transition? I haven't notice that.

[hrydgard]

When you score a point, the camera switches to look at the player. Except with this merge, only a solid blue background was seen when I tried it...

[weihuoya]

play on my s7edge, qualcomm version. seems work ok.

[unknownbrackets]

@hrydgard is it possible to capture a GE dump of that scene?

-[Unknown]

[hrydgard]

I'll retest soon.

[weihuoya]

point, line and quad need cull off, only cull triangles. and there is a issue with GE_CMD_CULLFACEENABLE, fixed.

[hrydgard]

Sorry for my slowness, I will actually test again soon :)

[ghost]

Waiting this in v1.8.0 milestones?

[unknownbrackets]

Worth testing this again with #11574 applied (since it fixes some lighting bugs that affect Virtua Tennis.)

-[Unknown]

[hrydgard]

I don't see any issues in Virtua Tennis, hard to explain why I saw them before...

Let's try this.

[hrydgard]

@weihuoya Wanna take a look at #11591?

[weihuoya]

ok, I will check it out.