Allow WASAPI device switching #11438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DualShock 4's headphone jack uses this, for example.
No support for specifying a certain device.
|
Strange how a couple of old commits of mine show up here, did you pull them from some branch? Anyway, this seems completely fine. |
|
Yes, the branch mentioned in #9805, where you tried adding the notification client. -[Unknown] |
|
Oh, completely forgot about that one :) |
This was referenced May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply follows the default audio device. We were already using eMultimedia, but technically MSDN says to use eConsole for games. Not sure it matters, I left it at eMultimedia... seems more logical as a user...
Anyway, this also adds support for direct IEEE_FLOAT format (non-extensible), which the DualShock 4 headphone jack uses. With these changes, switching devices works seemlessly.
Fixes #9805. Potentially, we could try detecting some property changes as a new device too, and also trigger this same logic - in case some headphone jacks operate that way and have different format params.
Sorry for all the refactoring in the last commit, was hard to split it up in any terribly useful way. It just calls
HasDeviceChanged()and reinits the device inside the render loop.Could also help #11367, perhaps.
-[Unknown]